Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1229023003: X87: Fix memento initialization when constructing from new call (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Fix memento initialization when constructing from new call port 3285e3bf071a2575a827c5b29fe389a72dbf8966 (r29719). original commit message: Additionally, push the allocation site or undefined independently of creatin BUG= Committed: https://crrev.com/3536562e184dc66c8b8165cecd135e4c6fca21e6 Cr-Commit-Position: refs/heads/master@{#29723}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M src/x87/builtins-x87.cc View 3 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 5 months ago (2015-07-17 09:39:42 UTC) #2
Weiliang
lgtm
5 years, 5 months ago (2015-07-17 09:41:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229023003/1
5 years, 5 months ago (2015-07-17 09:41:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-17 10:07:07 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 10:07:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3536562e184dc66c8b8165cecd135e4c6fca21e6
Cr-Commit-Position: refs/heads/master@{#29723}

Powered by Google App Engine
This is Rietveld 408576698