Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1229013003: Fix typo in non-SIMD Sk4f::thenElse(). (Closed)

Created:
5 years, 5 months ago by mtklein_C
Modified:
5 years, 5 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix typo in non-SIMD Sk4f::thenElse(). This was causing the 3 xfermodes that use floats and conditionals to draw wrong when SKNX_NO_SIMD was defined. BUG=skia:4051 Committed: https://skia.googlesource.com/skia/+/bfd9ee67eff5262dc1a395cf4f757419f5928718

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/core/SkNx.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
mtklein
lgtm
5 years, 5 months ago (2015-07-14 12:16:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229013003/1
5 years, 5 months ago (2015-07-14 12:16:26 UTC) #4
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 12:23:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bfd9ee67eff5262dc1a395cf4f757419f5928718

Powered by Google App Engine
This is Rietveld 408576698