Chromium Code Reviews Chromium Code Reviews
Issue 1228983003:
[CSS Grid Layout] Do not stretch always grid items with auto width (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/fast/css-grid-layout/min-width-height-auto.html |
| diff --git a/LayoutTests/fast/css-grid-layout/min-width-height-auto.html b/LayoutTests/fast/css-grid-layout/min-width-height-auto.html |
| index b5d07baf7ac90dea0aaea584ad16779065d79553..a50e564b56373d80b0a4c9dcfce3815b4668e169 100644 |
| --- a/LayoutTests/fast/css-grid-layout/min-width-height-auto.html |
| +++ b/LayoutTests/fast/css-grid-layout/min-width-height-auto.html |
| @@ -35,6 +35,10 @@ |
| max-width: 150px; |
| max-height: 75px; |
| } |
| + |
| +.noStretch { |
| + justify-items: start; |
| +} |
| </style> |
| <script src="../../resources/check-layout.js"></script> |
| <body onload="checkLayout('.grid')"> |
| @@ -71,5 +75,49 @@ |
| </div> |
| </div> |
| +<!-- Verifying that the same cases without 'stretch' work as expected as well. --> |
|
svillar
2015/07/28 15:14:07
Nit: I think we tend to write imperatives instead
jfernandez
2015/07/28 21:31:50
Acknowledged.
|
| +<div class="container"> |
| + <div class="grid noStretch"> |
| + <div class="ahem" data-expected-width="100" data-expected-height="25">XXXX</div> |
| + </div> |
| +</div> |
| + |
| +<div class="container"> |
| + <div class="grid noStretch"> |
| + <div class="ahem minSmaller" data-expected-width="100" data-expected-height="10">XXXX</div> |
| + </div> |
| +</div> |
| + |
| +<div class="container"> |
| + <div class="grid noStretch"> |
| + <div class="ahem minBigger" data-expected-width="150" data-expected-height="75">XXXX</div> |
| + </div> |
| +</div> |
| + |
| +<div class="container"> |
| + <div class="grid noStretch"> |
| + <div class="ahem maxSmaller" data-expected-width="10" data-expected-height="10">XXXX</div> |
| + </div> |
| +</div> |
| + |
| +<div class="container"> |
| + <div class="grid noStretch"> |
| + <div class="ahem maxBigger" data-expected-width="100" data-expected-height="25">XXXX</div> |
| + </div> |
| +</div> |
| + |
| +<!-- Verifying we are applying correctly the min-content size. --> |
|
svillar
2015/07/28 15:14:07
Ditto.
jfernandez
2015/07/28 21:31:50
Acknowledged.
|
| +<div class="container"> |
| + <div class="grid"> |
| + <div class="ahem" data-expected-width="75" data-expected-height="50">XXX X</div> |
| + </div> |
| +</div> |
| + |
| +<div class="container"> |
| + <div class="grid noStretch"> |
| + <div class="ahem" data-expected-width="75" data-expected-height="50">XXX X</div> |
| + </div> |
| +</div> |
| + |
| </body> |
| </html> |
