Chromium Code Reviews Chromium Code Reviews
Issue 1228983003:
[CSS Grid Layout] Do not stretch always grid items with auto width (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/fast/css-grid-layout/relayout-justify-self-changed.html |
| diff --git a/LayoutTests/fast/css-grid-layout/relayout-justify-self-changed.html b/LayoutTests/fast/css-grid-layout/relayout-justify-self-changed.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..a97dbc41340cc76c9c442142be591c5e0c0e4966 |
| --- /dev/null |
| +++ b/LayoutTests/fast/css-grid-layout/relayout-justify-self-changed.html |
| @@ -0,0 +1,39 @@ |
| +<!DOCTYPE HTML> |
| +<link href="resources/grid.css" rel="stylesheet"> |
| +<style> |
| +.grid { |
| + grid: 150px / 100px 100px; |
| + width: 150px; |
|
svillar
2015/07/10 14:00:53
Do we really need width: here?
jfernandez
2015/07/10 15:07:25
See my comments above.
|
| + position: relative; |
| +} |
| +.fromStretch { justify-self: stretch; } |
| +.toStretch { justify-self: end; } |
| +</style> |
| +<script src="../../resources/check-layout.js"></script> |
| +<p style="height: 20px">Tests how a justify-self style change requires a relayout of the grid and previously stretched items.</p> |
|
svillar
2015/07/10 14:00:53
why height on the <p> element?
jfernandez
2015/07/10 15:07:25
Done.
|
| +<p>The grid bellow had initially 'justify-self: end' and was changed to 'stretch'.</p> |
| +<div class="grid"> |
| + <div style="height: 50px;" class="toStretch firstRowFirstColumn" data-expected-width="150" data-offset-x="0"> |
|
svillar
2015/07/10 14:00:53
Perhaps we could set the height in the child the
jfernandez
2015/07/10 15:07:25
See my comments above.
|
| + <div style="width: 50px;"></div> |
| + </div> |
| + <div style="height: 50px;" class="toStretch secondRowFirstColumn" data-expected-width="150" data-offset-x="0"> |
| + <div style="width: 100px;"></div> |
| + </div> |
| +</div> |
| +<p>The grid bellow was initially stretched and it has now 'justify-self: center'.</p> |
| +<div class="grid"> |
| + <div style="height: 50px;" class="fromStretch firstRowFirstColumn" data-expected-width="50" data-offset-x="50"> |
| + <div style="width: 50px;"></div> |
| + </div> |
| + <div style="height: 50px;" class="fromStretch secondRowFirstColumn" data-expected-width="100" data-offset-x="25"> |
| + <div style="width: 100px;"></div> |
| + </div> |
| +</div> |
| +<script> |
| +document.body.offsetLeft; |
| +document.getElementsByClassName('toStretch')[0].style.justifySelf = 'stretch'; |
| +document.getElementsByClassName('toStretch')[1].style.justifySelf = 'stretch'; |
| +document.getElementsByClassName('fromStretch')[0].style.justifySelf = 'center'; |
| +document.getElementsByClassName('fromStretch')[1].style.justifySelf = 'center'; |
| +checkLayout(".grid"); |
| +</script> |
