|
[CSS Grid Layout] Do not stretch always grid items with auto width
We assumed that any grid item with 'auto' width will be stretched to fill
all the available space in its grid area. We assumed this because grid
area acts as item's container.
However, Grid Layout specification states on its Alignment section that
items will be stretched by default, unless either justify-self or align-self
compute to a value other than stretch or margins are auto. In those cases,
grid items will auto-size to fit their contents.
BUG= 249451
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199819
Total comments: 26
Total comments: 7
Total comments: 4
Total comments: 6
Total comments: 4
Total comments: 28
Total comments: 7
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+353 lines, -86 lines) |
Patch |
|
M |
LayoutTests/fast/css-grid-layout/grid-align-justify-stretch.html
|
View
|
1
2
3
4
5
|
3 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
|
M |
LayoutTests/fast/css-grid-layout/grid-item-auto-margins-and-stretch.html
|
View
|
|
6 chunks |
+12 lines, -12 lines |
0 comments
|
Download
|
|
M |
LayoutTests/fast/css-grid-layout/grid-items-should-not-be-stretched-when-height-or-margin-change.html
|
View
|
1
2
3
4
5
6
|
1 chunk |
+0 lines, -37 lines |
0 comments
|
Download
|
|
M |
LayoutTests/fast/css-grid-layout/grid-items-should-not-be-stretched-when-height-or-margin-change-expected.txt
|
View
|
1
2
3
4
5
6
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/css-grid-layout/grid-items-should-not-be-stretched-when-height-or-width-or-margin-change.html
|
View
|
1
2
3
4
5
6
|
1 chunk |
+46 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/css-grid-layout/grid-items-should-not-be-stretched-when-height-or-width-or-margin-change-expected.txt
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
LayoutTests/fast/css-grid-layout/min-width-height-auto.html
|
View
|
1
2
3
4
5
6
7
8
9
|
2 chunks |
+48 lines, -0 lines |
0 comments
|
Download
|
|
M |
LayoutTests/fast/css-grid-layout/min-width-height-auto-expected.txt
|
View
|
1
2
3
4
5
|
1 chunk |
+14 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/css-grid-layout/relayout-align-items-changed.html
|
View
|
1
|
1 chunk |
+36 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/css-grid-layout/relayout-align-items-changed-expected.txt
|
View
|
|
1 chunk |
+8 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/css-grid-layout/relayout-align-self-changed.html
|
View
|
1
|
1 chunk |
+39 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/css-grid-layout/relayout-align-self-changed-expected.txt
|
View
|
|
1 chunk |
+8 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/css-grid-layout/relayout-justify-items-changed.html
|
View
|
1
|
1 chunk |
+37 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/css-grid-layout/relayout-justify-items-changed-expected.txt
|
View
|
|
1 chunk |
+8 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/css-grid-layout/relayout-justify-self-changed.html
|
View
|
1
|
1 chunk |
+39 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/css-grid-layout/relayout-justify-self-changed-expected.txt
|
View
|
|
1 chunk |
+8 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/layout/LayoutBox.cpp
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/layout/LayoutGrid.h
|
View
|
1
2
3
4
5
6
7
8
9
10
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/layout/LayoutGrid.cpp
|
View
|
1
2
3
4
5
6
7
8
9
10
|
3 chunks |
+36 lines, -24 lines |
0 comments
|
Download
|
Total messages: 23 (3 generated)
|