Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 12289021: cc: Only register live tiles with the TileManager (Closed)

Created:
7 years, 10 months ago by ccameron
Modified:
7 years, 9 months ago
Reviewers:
nduca, reveman, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Only register live tiles with the TileManager Instead of registering a tile with the TileManager when it is created, only do so when the tile has a non-zero chance of being rasterized. Use a self-owned scoped_refptr to specify that a ManagedTilesState may not be freed (e.g, because it is being painted) instead of a bool because the ManagedTileState may now be unregistered at any point (even during painting). BUG=165852

Patch Set 1 #

Patch Set 2 : Add comments, fix 80+char line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -23 lines) Patch
M cc/picture_layer_tiling.h View 2 chunks +8 lines, -0 lines 0 comments Download
M cc/picture_layer_tiling.cc View 4 chunks +14 lines, -3 lines 0 comments Download
M cc/picture_layer_tiling_set_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/tile_manager.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/tile_manager.cc View 1 13 chunks +18 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ccameron
This is patch 2 of 3 patches which make the TileManager only be aware of ...
7 years, 10 months ago (2013-02-16 14:47:52 UTC) #1
reveman
7 years, 10 months ago (2013-02-19 01:43:51 UTC) #2
On 2013/02/16 14:47:52, ccameron1 wrote:
> Also of note is that this uses scoped_refptr<> a lot. It looks like that
> structure
> is thread-safe, so I'd like some reassurance that it isn't death for
performance
> (and if it is, a suggested alternative that doesn't give any thread safety 
> guarantees).

I'd assume scoped_refptr<> is only affected by thread-safe related code when
used with RefCountedThreadSafe objects.

Powered by Google App Engine
This is Rietveld 408576698