Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 12289020: cc: Make the TileManager operate on ManagedTileState directly (Closed)

Created:
7 years, 10 months ago by ccameron
Modified:
7 years, 9 months ago
Reviewers:
nduca, reveman, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Make the TileManager operate on ManagedTileState directly Change the TileManager to operate on ManagedTileState, so that it can be made unaware of Tiles that are unimportant (rather than storing them in separate structures). Change the TileMap to hold a TileHandle structure, which holds a scoped_refptr to a separate Tile and ManagedTileState. These are always allocated together, but will be separated soon. Make the ManagedTileState hold a scoped_refptr to its owning Tile. This allows the patch to minimize risk by not trying to duplicate and track the state of hte Tile in the ManagedTileState. It may be that future patches will want to do this. The destruction order is that the PictureLayerTiling will clear its TileMap, which will cause the TileHandle to be freed, which will cause the ManagedTilesTate to be freed, which will cause (or allow) the Tile state to be freed. BUG=165852

Patch Set 1 #

Patch Set 2 : Resolve against HEAD #

Patch Set 3 : Fix clang dtor nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+283 lines, -245 lines) Patch
M cc/picture_layer_tiling.h View 1 2 4 chunks +13 lines, -2 lines 0 comments Download
M cc/picture_layer_tiling.cc View 1 2 8 chunks +20 lines, -8 lines 0 comments Download
M cc/picture_layer_tiling_set_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/tile.h View 4 chunks +14 lines, -8 lines 0 comments Download
M cc/tile.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/tile_manager.h View 8 chunks +32 lines, -24 lines 0 comments Download
M cc/tile_manager.cc View 18 chunks +198 lines, -197 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ccameron
This is patch 1 of 3 patches which make the TileManager only be aware of ...
7 years, 10 months ago (2013-02-16 13:38:24 UTC) #1
reveman
7 years, 10 months ago (2013-02-19 01:40:31 UTC) #2
I like this incremental approach. Thanks for doing this.

Powered by Google App Engine
This is Rietveld 408576698