Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1552)

Unified Diff: chrome/browser/devtools/devtools_window_testing.cc

Issue 1228863006: devtools: avoid relying on the internal variables for browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add DetachFromBrowser() Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_window.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_window_testing.cc
diff --git a/chrome/browser/devtools/devtools_window_testing.cc b/chrome/browser/devtools/devtools_window_testing.cc
index 26fa6e3d7ad74dbe0395c5a2e1573d9b05e5054f..689e6f2d14e710c6b05aa6f93d0430a91cd2871f 100644
--- a/chrome/browser/devtools/devtools_window_testing.cc
+++ b/chrome/browser/devtools/devtools_window_testing.cc
@@ -65,7 +65,7 @@ DevToolsWindowTesting* DevToolsWindowTesting::Find(DevToolsWindow* window) {
}
Browser* DevToolsWindowTesting::browser() {
- return devtools_window_->browser_;
+ return devtools_window_->GetBrowser();
}
content::WebContents* DevToolsWindowTesting::main_web_contents() {
@@ -136,10 +136,10 @@ DevToolsWindow* DevToolsWindowTesting::OpenDevToolsWindowForWorkerSync(
// static
void DevToolsWindowTesting::CloseDevToolsWindow(
DevToolsWindow* window) {
- if (window->is_docked_) {
+ if (window->IsDocked()) {
window->CloseWindow();
} else {
- window->browser_->window()->Close();
+ window->GetBrowser()->window()->Close();
}
}
« no previous file with comments | « chrome/browser/devtools/devtools_window.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698