Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Unified Diff: chrome/browser/devtools/devtools_window.h

Issue 1228863006: devtools: avoid relying on the internal variables for browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add DetachFromBrowser() Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_window.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_window.h
diff --git a/chrome/browser/devtools/devtools_window.h b/chrome/browser/devtools/devtools_window.h
index c95bffb2e5132964fbd4597ffb4a02144d47e612..39950c1f869152c611ccc831d8d29f5db3ca2602 100644
--- a/chrome/browser/devtools/devtools_window.h
+++ b/chrome/browser/devtools/devtools_window.h
@@ -297,7 +297,7 @@ class DevToolsWindow : public DevToolsUIBindings::Delegate,
InfoBarService* GetInfoBarService() override;
void RenderProcessGone(bool crashed) override;
- void CreateDevToolsBrowser();
+ Browser* CreateDevToolsBrowser();
BrowserWindow* GetInspectedBrowserWindow();
void ScheduleShow(const DevToolsToggleAction& action);
void Show(const DevToolsToggleAction& action);
@@ -305,6 +305,10 @@ class DevToolsWindow : public DevToolsUIBindings::Delegate,
void LoadCompleted();
void UpdateBrowserToolbar();
void UpdateBrowserWindow();
+ Browser* GetBrowser();
+ bool IsDocked();
+ void DetachFromBrowser();
+
content::WebContents* GetInspectedWebContents();
scoped_ptr<ObserverWithAccessor> inspected_contents_observer_;
@@ -313,8 +317,7 @@ class DevToolsWindow : public DevToolsUIBindings::Delegate,
content::WebContents* main_web_contents_;
content::WebContents* toolbox_web_contents_;
DevToolsUIBindings* bindings_;
- Browser* browser_;
- bool is_docked_;
+ bool dock_requested_;
const bool can_dock_;
LifeStage life_stage_;
DevToolsToggleAction action_on_load_;
« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698