Runtime checks so that CoreBluetooth only used on >= 10.10

device/bluetooth/bluetooth_low_energy_discovery_manager_mac.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_BLUETOOTH_BLUETOOTH_LOW_ENERGY_DISCOVERY_MANAGER_MAC_H_

[scheib, 2015/07/09 19:51:23]

Consider adding a static method to this class so that all call sites can check
e.g.  BluetoothLowEnergyDiscoveryManagerMac::IsLowEnergyAvailable() and
centralize the detail of this being OSX >= 10.10 there.

[krstnmnlsn, 2015/07/10 17:17:46]

I like this idea a lot.  Added the method to mac adapter because it made the
most sense to me..

 #define DEVICE_BLUETOOTH_BLUETOOTH_LOW_ENERGY_DISCOVERY_MANAGER_MAC_H_
 
 #if defined(OS_IOS)
 #import <CoreBluetooth/CoreBluetooth.h>
 #else
 #import <IOBluetooth/IOBluetooth.h>
 #endif
 
 #include "base/mac/scoped_nsobject.h"
 #include "base/mac/sdk_forward_declarations.h"
@@ skipping 57 matching lines @@
   // |bridge_| as its delegate.  Only for use on OSX 10.7 or later, where
   // CoreBluetooth is available.
   virtual void SetManagerForTesting(CBCentralManager* manager);
 
   friend class BluetoothLowEnergyDiscoveryManagerMacDelegate;
   friend class BluetoothAdapterMacTest;
 
   // Observer interested in notifications from us.
   Observer* observer_;
 
-  // Underlying CoreBluetooth central manager.
-  //
-  // Note: Intentionally leaked. Deallocating CBCentralManager
-  // results in a crash, at least when running OSX 10.9.5 on a
-  // mac_chromuim_rel_ng trybot. On the other hand, restricting |manager_| use
-  // to 10.10 and later would mean the code is unrun and untested by the current
-  // trybots. To work around this we call retain on |manager_| after allocation,
-  // so that the object is leaked.
+  // Underlying CoreBluetooth central manager.  Should only be instantiated on
+  // OS X >= 10.10 as was found to crash on the mac_chromium_rel_ng trybot
+  // running 10.9.5.  May also cause blued to crash on OS X 10.9.5
+  // (crbug.com/506287).
   base::scoped_nsobject<CBCentralManager> manager_;
 
   // Discovery has been initiated by calling the API StartDiscovery().
   bool discovering_;
 
   // A discovery has been initiated but has not started yet because it's
   // waiting for Bluetooth to turn on.
   bool pending_;
 
   // Delegate of the central manager.
   base::scoped_nsobject<BluetoothLowEnergyDiscoveryManagerMacBridge> bridge_;
 
   // List of service UUIDs to scan.
   BluetoothDevice::UUIDList services_uuids_;
 
   DISALLOW_COPY_AND_ASSIGN(BluetoothLowEnergyDiscoveryManagerMac);
 };
 
 }  // namespace device
 
 #endif  // DEVICE_BLUETOOTH_BLUETOOTH_LOW_ENERGY_DISCOVERY_MANAGER_MAC_H_