Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: src/core/SkPaintPriv.h

Issue 1228853005: rename utility to see if a paint will overwrite its pixels (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/core/SkPaintPriv.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkPaintPriv.h
diff --git a/src/core/SkPaintPriv.h b/src/core/SkPaintPriv.h
index be441b8f7225f2e07caa0e021a95735a22a1bf7e..d859132391c06c774c89ba0db546dca82a930366 100644
--- a/src/core/SkPaintPriv.h
+++ b/src/core/SkPaintPriv.h
@@ -14,34 +14,27 @@ class SkBitmap;
class SkImage;
class SkPaint;
-enum SkPaintBitmapOpacity {
- // No content replaces the paint's color
- kNoBitmap_SkPaintBitmapOpacity = 0,
- // The color replacement is known to be opaque
- kOpaque_SkPaintBitmapOpacity = 1,
- // We have no information about the color or it is transparent
- kUnknown_SkPaintBitmapOpacity = 2
-};
+class SkPaintPriv {
+public:
+ /**
+ * Returns true if drawing with this paint (or NULL) will ovewrite all affected pixels.
+ *
+ * Note: returns conservative true, meaning it may return false even though the paint might
+ * in fact overwrite its pixels.
+ */
+ static bool Overwrites(const SkPaint& paint);
-/** Returns true if draw calls that use the paint will completely occlude
- canvas contents that are covered by the draw.
- @param paint The paint to be analyzed, NULL is equivalent to
- the default paint.
- @param contentType The type of the content that will be drawn,
- kNoBitmap_SkPaintBitmapOpacity if there is no content in adition to the paint.
- @return true if paint is opaque
-*/
-bool isPaintOpaque(const SkPaint* paint, SkPaintBitmapOpacity contentType);
+ /**
+ * Returns true if drawing this bitmap with this paint (or NULL) will ovewrite all affected
+ * pixels.
+ */
+ static bool Overwrites(const SkBitmap&, const SkPaint* paint);
-/** Returns true if draw calls that use the paint will completely occlude
- canvas contents that are covered by the draw.
- @param paint The paint to be analyzed, NULL is equivalent to
- the default paint.
- @param bmpReplacesShader a bitmap to be used in place of the paint's
- shader.
- @return true if paint is opaque
-*/
-bool isPaintOpaque(const SkPaint* paint, const SkBitmap* bmpReplacesShader = NULL);
-bool isPaintOpaque(const SkPaint* paint, const SkImage* image);
+ /**
+ * Returns true if drawing this image with this paint (or NULL) will ovewrite all affected
+ * pixels.
+ */
+ static bool Overwrites(const SkImage*, const SkPaint* paint);
+};
#endif
« no previous file with comments | « no previous file | src/core/SkPaintPriv.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698