Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1228833003: Allow Android font manager on *nix. (Closed)

Created:
5 years, 5 months ago by bungeman-skia
Modified:
5 years, 5 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Allow Android font manager on *nix. There is nothing left in the SkFontMgr_android.cpp which is specific to Android, so allow it to be built and used on *nix platforms. This allows for easier development and testing. The only reason to limit to *nix platforms are the dependencies on Expat and FreeType. This should be buildable and runnable on other platforms when these dependencies are also available. Committed: https://skia.googlesource.com/skia/+/786ece17c3fac1aae670a6206ad4d11471a2488e

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove unintended whitespace. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -35 lines) Patch
M gyp/ports.gyp View 1 5 chunks +13 lines, -29 lines 0 comments Download
M gyp/tests.gypi View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228833003/1
5 years, 5 months ago (2015-07-13 20:46:04 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-13 20:53:29 UTC) #4
bungeman-skia
This is a step toward building and testing all the FreeType based font managers on ...
5 years, 5 months ago (2015-07-13 20:56:26 UTC) #6
djsollen
https://codereview.chromium.org/1228833003/diff/1/gyp/ports.gyp File gyp/ports.gyp (right): https://codereview.chromium.org/1228833003/diff/1/gyp/ports.gyp#newcode71 gyp/ports.gyp:71: remove newline https://codereview.chromium.org/1228833003/diff/1/gyp/ports.gyp#newcode133 gyp/ports.gyp:133: 'sources/': [['include', '../src/ports/SkFontMgr_android_factory.cpp']], I've never ...
5 years, 5 months ago (2015-07-15 13:48:48 UTC) #7
bungeman-skia
https://codereview.chromium.org/1228833003/diff/1/gyp/ports.gyp File gyp/ports.gyp (right): https://codereview.chromium.org/1228833003/diff/1/gyp/ports.gyp#newcode71 gyp/ports.gyp:71: On 2015/07/15 13:48:48, djsollen wrote: > remove newline Done. ...
5 years, 5 months ago (2015-07-15 17:08:48 UTC) #8
djsollen
lgtm
5 years, 5 months ago (2015-07-15 17:23:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228833003/20001
5 years, 5 months ago (2015-07-15 17:44:26 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 17:58:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/786ece17c3fac1aae670a6206ad4d11471a2488e

Powered by Google App Engine
This is Rietveld 408576698