Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1228823006: Do not try to compile x86 and x86_64 .asm files on Android (Closed)

Created:
5 years, 5 months ago by msarett
Modified:
5 years, 1 month ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Do not try to compile x86 and x86_64 .asm files on Android This is currently only works on Linux hosts because we have checked in a binary and does not work on Mac hosts. We are disabling until we find a suitable solution. BUG=skia:4028 Committed: https://skia.googlesource.com/skia/+/72394ef87c2ea023d00d79cd65013e1688ea30d3

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add new condition #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M gyp/libjpeg-turbo.gyp View 1 2 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
msarett
5 years, 5 months ago (2015-07-09 13:47:28 UTC) #2
djsollen
https://codereview.chromium.org/1228823006/diff/1/gyp/libjpeg-turbo.gyp File gyp/libjpeg-turbo.gyp (right): https://codereview.chromium.org/1228823006/diff/1/gyp/libjpeg-turbo.gyp#newcode118 gyp/libjpeg-turbo.gyp:118: 'conditions': [ skia_os = "android && (skia_arch_type == "x86" ...
5 years, 5 months ago (2015-07-09 14:09:18 UTC) #3
msarett
https://codereview.chromium.org/1228823006/diff/1/gyp/libjpeg-turbo.gyp File gyp/libjpeg-turbo.gyp (right): https://codereview.chromium.org/1228823006/diff/1/gyp/libjpeg-turbo.gyp#newcode118 gyp/libjpeg-turbo.gyp:118: 'conditions': [ On 2015/07/09 14:09:18, djsollen wrote: > skia_os ...
5 years, 5 months ago (2015-07-09 14:18:17 UTC) #4
djsollen
lgtm with one nit https://codereview.chromium.org/1228823006/diff/20001/gyp/libjpeg-turbo.gyp File gyp/libjpeg-turbo.gyp (right): https://codereview.chromium.org/1228823006/diff/20001/gyp/libjpeg-turbo.gyp#newcode119 gyp/libjpeg-turbo.gyp:119: 'conditions': [ this extra conditions ...
5 years, 5 months ago (2015-07-09 14:28:47 UTC) #5
msarett
https://codereview.chromium.org/1228823006/diff/20001/gyp/libjpeg-turbo.gyp File gyp/libjpeg-turbo.gyp (right): https://codereview.chromium.org/1228823006/diff/20001/gyp/libjpeg-turbo.gyp#newcode119 gyp/libjpeg-turbo.gyp:119: 'conditions': [ On 2015/07/09 14:28:47, djsollen wrote: > this ...
5 years, 5 months ago (2015-07-09 14:32:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228823006/40001
5 years, 5 months ago (2015-07-09 14:32:55 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 14:55:05 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/72394ef87c2ea023d00d79cd65013e1688ea30d3

Powered by Google App Engine
This is Rietveld 408576698