chrome/browser/extensions/api/passwords_private/passwords_private_delegate_factory.cc - Issue 1228813006: Avoid creating PasswordsPrivateDelegate when shutting down.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/passwords_private/passwords_private_delegate_factory.cc

Issue 1228813006: Avoid creating PasswordsPrivateDelegate when shutting down. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review issues. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/passwords_private/passwords_private_delegate_factory.h ('k') | chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/passwords_private/passwords_private_delegate_factory.cc

diff --git a/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_factory.cc b/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_factory.cc

index c535df14a082f91d1243b81748d4bfcf2747d66a..c73bf7fcc394f1dcfa6af4f274e2db4ce287d16a 100644

--- a/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_factory.cc

+++ b/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_factory.cc

@@ -16,9 +16,10 @@ using content::BrowserContext;

// static

PasswordsPrivateDelegate* PasswordsPrivateDelegateFactory::GetForBrowserContext(

- BrowserContext* browser_context) {

+ BrowserContext* browser_context,

+ bool create) {

return static_cast<PasswordsPrivateDelegate*>(

- GetInstance()->GetServiceForBrowserContext(browser_context, true));

+ GetInstance()->GetServiceForBrowserContext(browser_context, create));

}

// static