chrome/browser/extensions/api/passwords_private/passwords_private_api.cc - Issue 1228813006: Avoid creating PasswordsPrivateDelegate when shutting down.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/passwords_private/passwords_private_api.cc

Issue 1228813006: Avoid creating PasswordsPrivateDelegate when shutting down. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review issues. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/passwords_private/passwords_private_api.cc

diff --git a/chrome/browser/extensions/api/passwords_private/passwords_private_api.cc b/chrome/browser/extensions/api/passwords_private/passwords_private_api.cc

index 64f67f23bae9c7f2e333d4bd0f9dae02539677e1..4ed7fca726bd6a5560dc4a5109861bec0942a87d 100644

--- a/chrome/browser/extensions/api/passwords_private/passwords_private_api.cc

+++ b/chrome/browser/extensions/api/passwords_private/passwords_private_api.cc

@@ -40,7 +40,8 @@ ExtensionFunction::ResponseAction

EXTENSION_FUNCTION_VALIDATE(parameters.get());

PasswordsPrivateDelegate* delegate =

- PasswordsPrivateDelegateFactory::GetForBrowserContext(browser_context());

+ PasswordsPrivateDelegateFactory::GetForBrowserContext(browser_context(),

+ true /* create */);

delegate->RemoveSavedPassword(

parameters->login_pair.origin_url,

parameters->login_pair.username);

@@ -62,7 +63,8 @@ ExtensionFunction::ResponseAction

EXTENSION_FUNCTION_VALIDATE(parameters.get());

PasswordsPrivateDelegate* delegate =

- PasswordsPrivateDelegateFactory::GetForBrowserContext(browser_context());

+ PasswordsPrivateDelegateFactory::GetForBrowserContext(browser_context(),

+ true /* create */);

delegate->RemovePasswordException(parameters->exception_url);

return RespondNow(NoArguments());

@@ -82,7 +84,8 @@ ExtensionFunction::ResponseAction

EXTENSION_FUNCTION_VALIDATE(parameters.get());

PasswordsPrivateDelegate* delegate =

- PasswordsPrivateDelegateFactory::GetForBrowserContext(browser_context());

+ PasswordsPrivateDelegateFactory::GetForBrowserContext(browser_context(),

+ true /* create */);

delegate->RequestShowPassword(parameters->login_pair.origin_url,

parameters->login_pair.username,

« no previous file with comments | « no previous file | chrome/browser/extensions/api/passwords_private/passwords_private_delegate_factory.h » ('j') | no next file with comments »