dart/sdk/lib/_internal/compiler/implementation/lib/foreign_helper.dart - Issue 12288047: Change IsolateNatives.computeThisScript to use captured value of document.currentScript.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/lib/foreign_helper.dart

Issue 12288047: Change IsolateNatives.computeThisScript to use captured value of document.currentScript. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Use typeof object and don't use JS_CURRENT_ISOLATE before _globalState has been initialized. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('k') | dart/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/lib/foreign_helper.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/lib/foreign_helper.dart b/dart/sdk/lib/_internal/compiler/implementation/lib/foreign_helper.dart

index 97700a7bee865515680cfd605f294e0d467fc2a9..ac14c322a98fc27e80307b78b9beacdb3bf1bda3 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/lib/foreign_helper.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/lib/foreign_helper.dart

@@ -96,7 +96,13 @@ dynamic JS(String typeDescription, String codeTemplate,

/**

* Returns the isolate in which this code is running.

-dynamic JS_CURRENT_ISOLATE() {}

+IsolateContext JS_CURRENT_ISOLATE() {}

+abstract class IsolateContext {

+ /// Holds a (native) JavaScript instance of Isolate, see

+ /// finishIsolateConstructorFunction in emitter.dart.

+ get isolateStatics;

/**

* Invokes [function] in the context of [isolate].