Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Issue 12288046: Merge 182751 (Closed)

Created:
7 years, 10 months ago by csharp
Modified:
7 years, 10 months ago
Reviewers:
csharp
CC:
chromium-reviews, Raman Kakilate, estade+watch_chromium.org, benquan, browser-components-watch_chromium.org, ahutter, jam, dbeam+watch-autofill_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, dhollowa+watch_chromium.org, Albert Bodenhamer, Ilya Sherman
Visibility:
Public.

Description

Merge 182751 > Properly Remove Autofill Keyboard Listener. > > Remove the keyboard listener before we implicitly delete the object. Also > update the removal code to catch problems like this if they occur again. > > R=estade@chromium.org > BUG=175454 > > > Review URL: https://chromiumcodereview.appspot.com/12223106 TBR=csharp@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183210

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -52 lines) Patch
M chrome/browser/autofill/autofill_external_delegate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/autofill/autofill_external_delegate.cc View 3 chunks +11 lines, -7 lines 0 comments Download
M chrome/browser/autofill/autofill_external_delegate_browsertest.cc View 5 chunks +30 lines, -15 lines 0 comments Download
M chrome/browser/autofill/autofill_external_delegate_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_impl.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_impl.cc View 5 chunks +14 lines, -21 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
csharp
7 years, 10 months ago (2013-02-19 14:42:20 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698