Issue 1228803006: [es6] JSObject::GetOwnElementKeys should collect String wrapper keys first

Issue 1228803006: [es6] JSObject::GetOwnElementKeys should collect String wrapper keys first (Closed)

Created:
5 years, 5 months ago by adamk

Modified:
5 years, 5 months ago

Reviewers:
rossberg, Toon Verwaest

CC:
v8-dev, Dan Ehrenberg

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[es6] JSObject::GetOwnElementKeys should collect String wrapper keys first This makes Object.getOwnPropertyNames() return the integer keys in the proper order, following the spec: http://www.ecma-international.org/ecma-262/6.0/#sec-ordinary-object-internal-methods-and-internal-slots-ownpropertykeys BUG=v8:4118 LOG=n Committed: https://crrev.com/1e146c07088d4e0f5c25177be6b2245b562cb929 Cr-Commit-Position: refs/heads/master@{#29667}

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -15 lines)			Patch
	M	src/objects.cc	View		2 chunks	+17 lines, -12 lines	0 comments	Download
	M	test/test262-es6/test262-es6.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 8 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228803006/1

5 years, 5 months ago (2015-07-15 07:29:48 UTC) #6

commit-bot: I haz the power

5 years, 5 months ago (2015-07-15 07:31:52 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1e146c07088d4e0f5c25177be6b2245b562cb929
Cr-Commit-Position: refs/heads/master@{#29667}