Improve IsolateNatives.computeThisScript().

Improve IsolateNatives.computeThisScript().

Committed: https://code.google.com/p/dart/source/detail?r=18648

Committed: https://code.google.com/p/dart/source/detail?r=18664

[ngeoffray, 2013-02-18 15:52:08]

LGTM!

https://codereview.chromium.org/12288029/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart
(right):

https://codereview.chromium.org/12288029/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart:423:
'function() {try{throw new Error()}catch(e){return e.stack}}');
Please add the spaces.

[ahe, 2013-02-18 15:55:50]

https://codereview.chromium.org/12288029/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart
(right):

https://codereview.chromium.org/12288029/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart:423:
'function() {try{throw new Error()}catch(e){return e.stack}}');
On 2013/02/18 15:52:08, ngeoffray wrote:
> Please add the spaces.

Why? This code is copied directly into the minified output.

More importantly, I'm not invoking the function :-(

[ngeoffray, 2013-02-18 15:58:57]

https://codereview.chromium.org/12288029/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart
(right):

https://codereview.chromium.org/12288029/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart:423:
'function() {try{throw new Error()}catch(e){return e.stack}}');
On 2013/02/18 15:55:50, ahe wrote:
> On 2013/02/18 15:52:08, ngeoffray wrote:
> > Please add the spaces.
> 
> Why? This code is copied directly into the minified output.
> 
> More importantly, I'm not invoking the function :-(

Maybe I would have caught it if there was more spaces :-)

[ahe, 2013-02-18 18:10:31]

https://codereview.chromium.org/12288029/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart
(right):

https://codereview.chromium.org/12288029/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart:423:
'function() {try{throw new Error()}catch(e){return e.stack}}');
On 2013/02/18 15:58:57, ngeoffray wrote:
> On 2013/02/18 15:55:50, ahe wrote:
> > On 2013/02/18 15:52:08, ngeoffray wrote:
> > > Please add the spaces.
> > 
> > Why? This code is copied directly into the minified output.
> > 
> > More importantly, I'm not invoking the function :-(
> 
> Maybe I would have caught it if there was more spaces :-)

Done.

[ahe, 2013-02-19 09:19:40]

PTAL

Reopened CL and corrected the regular expression to work on IE. Before it only
worked by accident on Chrome and Safari as the stack traces look like this:

Error
   at $.IsolateNatives_computeThisScript (out.js:1250:11)
   at $.main (out.js:1595:18)
   at out.js:1742:7

The regular expression was matching the last line, not the second line as
intended.

[ngeoffray, 2013-02-19 09:36:37]

LGTM