Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 12288015: Add examples to placeholders that don't have them. (Closed)

Created:
7 years, 10 months ago by tony
Modified:
7 years, 10 months ago
Reviewers:
Jói
CC:
chromium-reviews, Sergiu, bulach
Visibility:
Public.

Description

Add examples to placeholders that don't have them. This fixes some lint warnings on the translation console. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183248

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/app/generated_resources.grd View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tony
7 years, 10 months ago (2013-02-15 23:27:17 UTC) #1
Jói
7 years, 10 months ago (2013-02-18 10:08:11 UTC) #2
LGTM

On Fri, Feb 15, 2013 at 11:27 PM,  <tony@chromium.org> wrote:
> Reviewers: Jói,
>
> Description:
> Add examples to placeholders that don't have them.
>
> This fixes some lint warnings on the translation console.
>
> BUG=None
>
>
> Please review this at https://codereview.chromium.org/12288015/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>   M chrome/app/generated_resources.grd
>
>
> Index: chrome/app/generated_resources.grd
> diff --git a/chrome/app/generated_resources.grd
> b/chrome/app/generated_resources.grd
> index
>
0c53a93ffd74f886237c2b0e8e9bf7c87d3059d5..5d57d2b7c6a46a1388600a61efde2fde7c3d820c
> 100644
> --- a/chrome/app/generated_resources.grd
> +++ b/chrome/app/generated_resources.grd
> @@ -484,7 +484,7 @@ Psst! Incognito mode <ph
> name="SHORTCUT_KEY">$1<ex>(Ctrl+Shift+N)</ex></ph> may
>          Today
>        </message>
>        <message name="IDS_HISTORY_NUMBER_VISITS" desc="Format string for the
> number of visits of a site.">
> -        (<ph name="NUMBER_VISITS">$1</ph>)
> +        (<ph name="NUMBER_VISITS">$1<ex>3</ex></ph>)
>        </message>
>
>        <!-- Generic terms -->
> @@ -9522,7 +9522,7 @@ The following plug-in is unresponsive: <ph
> name="PLUGIN_NAME">$1
>          <message name="IDS_ERRORPAGES_SUGGESTION_PROXY_CONFIG" desc="When a
> webpage fails to load, in some cases we suggest checking the proxy server
> configuration, or disabling the proxy server.">
>            If you use a proxy server, check your proxy settings or contact
> your
>            network administrator to make sure the proxy server is working.
> -          <ph name="PLATFORM_TEXT">$1</ph>
> +          <ph name="PLATFORM_TEXT">$1<ex>Goto the wrench menu and choose
> Fix It.</ex></ph>
>          </message>
>        </if>
>        <if expr="not pp_ifdef('android') and not pp_ifdef('ios')">
> @@ -9531,7 +9531,7 @@ The following plug-in is unresponsive: <ph
> name="PLUGIN_NAME">$1
>            network administrator to make sure the proxy server is working.
> If you
>            don't believe you should be using a proxy server, adjust your
> proxy
>            settings:
> -          <ph name="PLATFORM_TEXT">$1<ex>Goto the wrench menu and choose
> Fix It</ex></ph>
> +          <ph name="PLATFORM_TEXT">$1<ex>Goto the wrench menu and choose
> Fix It.</ex></ph>
>          </message>
>        </if>
>        <message name="IDS_ERRORPAGES_SUGGESTION_LEARNMORE" desc="When a
> webpage fails to load, we provide a link to the help center to learn more
> about the failure.">
>
>

Powered by Google App Engine
This is Rietveld 408576698