Showing launcher items for windowed v1 apps - pinned or not. Also - don't show windowed v1 apps in …

chrome/browser/ui/ash/launcher/browser_launcher_item_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/launcher/browser_launcher_item_controller.h"
 
 #include "ash/launcher/launcher.h"
 #include "ash/launcher/launcher_model.h"
 #include "ash/shell.h"
 #include "ash/wm/window_util.h"
@@ skipping 15 matching lines @@
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/views/widget/widget.h"
 
 using extensions::Extension;
 
 BrowserLauncherItemController::BrowserLauncherItemController(
     Type type,
     aura::Window* window,
     TabStripModel* tab_model,
     ChromeLauncherController* launcher_controller,
-    const std::string& app_id)
+    const std::string& app_id,
+    const std::string& v1_app_id)
     : LauncherItemController(type, app_id, launcher_controller),
       window_(window),
+      v1_app_id_(v1_app_id),
       tab_model_(tab_model),
       is_incognito_(tab_model->profile()->GetOriginalProfile() !=
                     tab_model->profile() &&
                     !tab_model->profile()->IsGuestSession()) {
   DCHECK(window_);
   window_->AddObserver(this);
 }
 
 BrowserLauncherItemController::~BrowserLauncherItemController() {
   tab_model_->RemoveObserver(this);
   window_->RemoveObserver(this);
   if (launcher_id() > 0)
     launcher_controller()->CloseLauncherItem(launcher_id());
+  if (type() == TYPE_WINDOWED_APP)
+    launcher_controller()->UnlockAppWithID(v1_app_id_);

[sky, 2013/02/19 17:55:56]

Why do you need the lock/unlock? Shouldn't that be handled by way of
CloseLauncherItem and CreateTabbedLauncherItem?

[Mr4D (OOO till 08-26), 2013/02/19 19:22:13]

As discussed.

 }
 
 void BrowserLauncherItemController::Init() {
   tab_model_->AddObserver(this);
   ash::LauncherItemStatus app_status =
       ash::wm::IsActiveWindow(window_) ?
       ash::STATUS_ACTIVE : ash::STATUS_RUNNING;
-  if (type() != TYPE_TABBED) {
+  if (type() != TYPE_TABBED && type() != TYPE_WINDOWED_APP) {
     launcher_controller()->CreateAppLauncherItem(this, app_id(), app_status);
   } else {
     launcher_controller()->CreateTabbedLauncherItem(
         this,
         is_incognito_ ? ChromeLauncherController::STATE_INCOGNITO :
                         ChromeLauncherController::STATE_NOT_INCOGNITO,
         app_status);
+    if (type() == TYPE_WINDOWED_APP)
+      launcher_controller()->LockAppWithID(v1_app_id_);
   }
   // In testing scenarios we can get tab strips with no active contents.
   if (tab_model_->active_index() != TabStripModel::kNoTab)
     UpdateLauncher(tab_model_->GetActiveWebContents());
 }
 
 // static
 BrowserLauncherItemController* BrowserLauncherItemController::Create(
     Browser* browser) {
   // Under testing this can be called before the controller is created.
   if (!ChromeLauncherController::instance())
     return NULL;
 
   Type type;
   std::string app_id;
+  std::string v1_app_id;
   if (browser->is_type_tabbed() || browser->is_type_popup()) {
     type = TYPE_TABBED;
+    if (!browser->is_type_tabbed() &&
+        browser->is_type_popup() &&
+        browser->is_app() &&
+        ChromeLauncherController::instance()->GetPerAppInterface()) {
+      v1_app_id = web_app::GetExtensionIdFromApplicationName(
+                      browser->app_name());
+      // Only allow this for known applications. Some unit tests for example
+      // do not have one.
+      if (!v1_app_id.empty())
+        type = TYPE_WINDOWED_APP;
+    }
   } else if (browser->is_app()) {
     if (browser->is_type_panel()) {
       if (browser->app_type() == Browser::APP_TYPE_CHILD)
         type = TYPE_EXTENSION_PANEL;
       else
         type = TYPE_APP_PANEL;
     } else {
       type = TYPE_TABBED;
     }
     app_id = web_app::GetExtensionIdFromApplicationName(browser->app_name());
   } else {
     return NULL;
   }
   BrowserLauncherItemController* controller =
       new BrowserLauncherItemController(type,
                                         browser->window()->GetNativeWindow(),
                                         browser->tab_strip_model(),
                                         ChromeLauncherController::instance(),
-                                        app_id);
+                                        app_id,
+                                        v1_app_id);
   controller->Init();
   return controller;
 }
 
 void BrowserLauncherItemController::BrowserActivationStateChanged() {
   content::WebContents* active_contents = tab_model_->GetActiveWebContents();
   if (active_contents)
     UpdateAppState(active_contents);
   UpdateItemStatus();
 }
@@ skipping 211 matching lines @@
       app_state = ChromeLauncherController::APP_STATE_ACTIVE;
   } else {
     app_state = ChromeLauncherController::APP_STATE_INACTIVE;
   }
   launcher_controller()->UpdateAppState(tab, app_state);
 }
 
 ash::LauncherModel* BrowserLauncherItemController::launcher_model() {
   return launcher_controller()->model();
 }