Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Issue 12288006: Merge 181867 (Closed)

Created:
7 years, 10 months ago by sail
Modified:
7 years, 10 months ago
Reviewers:
sail
CC:
chromium-reviews, sail+watch_chromium.org
Visibility:
Public.

Description

Merge 181867 > Alternate NTP: Fix dev tools layout > > When docked to the right the dev tool's web view would be cropped. > > This bug was due to the way I implemented view layout in r181301. > > The dev tool view was being correctly layed out but the subview was not. > > To fix this I've removed the container view (DevToolsContainerView). The new code just use the view's auto layout instead. > > BUG=173205 > TEST=Docked the devtools to the right and opened a new browser window. Verified that the devtools view was correctly layed out. > > Review URL: https://codereview.chromium.org/12226086 TBR=sail@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182776

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -23 lines) Patch
M chrome/browser/ui/cocoa/dev_tools_controller.mm View 2 chunks +11 lines, -23 lines 0 comments Download
M chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm View 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sail
7 years, 10 months ago (2013-02-15 19:12:08 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698