Cleanup of accessibility_tree_formatter_win.cc.

Cleanup of accessibility_tree_formatter_win.cc.

Switched to using ScopedBstr and removed memory leaks with BSTRs.
Switched to using SUCCESS macro instead of comparing to S_OK because there are methods which might return other success codes such as S_FALSE, the results of which  we would want to capture in tests.
Switched to using "auto" in some instances.
Renamed some variables to more descriptive or more concise names.
R=dmazzoni@chromium.org,aboxhall@chromium.org

Committed: https://crrev.com/b4b6c7c6a5386243795a7028fbffc5fc4fd40aac
Cr-Commit-Position: refs/heads/master@{#338112}

[aboxhall, 2015-07-09 14:47:14]

LGTM

Would be nice if you could be a little more descriptive in the change
description - what needed cleaning up and why?

[nektarios, 2015-07-09 16:11:22]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2015-07-09 16:11:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1228793003/1

[chromium-reviews, 2015-07-09 16:12:08]

Okay, the description has been amended to give details on what has changed.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[aboxhall, 2015-07-09 16:14:52]

On 2015/07/09 16:12:08, chromium-reviews wrote:
> Okay, the description has been amended to give details on what has changed.
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Looks great, thanks!

[commit-bot: I haz the power, 2015-07-09 16:50:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-09 16:50:19]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

(exceeded global retry quota)

[chromium-reviews, 2015-07-09 19:06:28]

I had to revert the inclusion of some S_FALSE results: current_value, 
max_value, min_value and caret_offset.
I want to have the ability to tell if the caret is not on a specific 
object. According to the IA2 Spec the relevant API should return S_FALSE 
(a success code) and an offset of -1. However, this makes many existing 
tests fail.
I'll solve the issue in another CL. This is not a clean up task.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[nektarios, 2015-07-09 19:18:28]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2015-07-09 19:18:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
aboxhall@chromium.org
Link to the patchset: https://codereview.chromium.org/1228793003/#ps20001
(title: "Removed S_FALSE results from some float attributes.")

[commit-bot: I haz the power, 2015-07-09 19:20:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1228793003/20001

[commit-bot: I haz the power, 2015-07-09 19:27:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-09 19:28:22]

Patchset 2 (id:??) landed as
https://crrev.com/b4b6c7c6a5386243795a7028fbffc5fc4fd40aac
Cr-Commit-Position: refs/heads/master@{#338112}