Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: src/gpu/GrPipelineBuilder.h

Issue 1228763005: small cleanups after fixing const of GrPipelineBuilder on DrawTarget (Closed) Base URL: https://skia.googlesource.com/skia.git@const-fix3
Patch Set: tweak Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/gpu/GrPipelineBuilder.h
diff --git a/src/gpu/GrPipelineBuilder.h b/src/gpu/GrPipelineBuilder.h
index 60fcea86c8a233ef37a7c68f2f3993403583d125..861773f9c11d187691beec741454dfb2f0322d7b 100644
--- a/src/gpu/GrPipelineBuilder.h
+++ b/src/gpu/GrPipelineBuilder.h
@@ -113,26 +113,33 @@ public:
* This class can transiently modify its "const" GrPipelineBuilder object but will restore it
* when done - so it is notionally "const" correct.
*/
- class AutoRestoreFragmentProcessors : public ::SkNoncopyable {
+ class AutoRestoreFragmentProcessorState : public ::SkNoncopyable {
public:
- AutoRestoreFragmentProcessors()
+ AutoRestoreFragmentProcessorState()
: fPipelineBuilder(NULL)
, fColorEffectCnt(0)
- , fCoverageEffectCnt(0) {}
+ , fCoverageEffectCnt(0)
+ , fSaveMarker(0) {}
- AutoRestoreFragmentProcessors(GrPipelineBuilder* ds)
+ AutoRestoreFragmentProcessorState(const GrPipelineBuilder& ds)
: fPipelineBuilder(NULL)
, fColorEffectCnt(0)
- , fCoverageEffectCnt(0) {
- this->set(ds);
+ , fCoverageEffectCnt(0)
+ , fSaveMarker(0) {
+ this->set(&ds);
}
- ~AutoRestoreFragmentProcessors() { this->set(NULL); }
+ ~AutoRestoreFragmentProcessorState() { this->set(NULL); }
void set(const GrPipelineBuilder* ds);
bool isSet() const { return SkToBool(fPipelineBuilder); }
+ GrProcessorDataManager* getProcessorDataManager() {
+ SkASSERT(this->isSet());
+ return fPipelineBuilder->getProcessorDataManager();
+ }
+
const GrFragmentProcessor* addCoverageProcessor(const GrFragmentProcessor* processor) {
SkASSERT(this->isSet());
return fPipelineBuilder->addCoverageProcessor(processor);
@@ -143,6 +150,7 @@ public:
GrPipelineBuilder* fPipelineBuilder;
int fColorEffectCnt;
int fCoverageEffectCnt;
+ uint32_t fSaveMarker;
};
/// @}
@@ -261,7 +269,7 @@ public:
public:
AutoRestoreStencil() : fPipelineBuilder(NULL) {}
- AutoRestoreStencil(const GrPipelineBuilder* ds) : fPipelineBuilder(NULL) { this->set(ds); }
+ AutoRestoreStencil(const GrPipelineBuilder& ds) : fPipelineBuilder(NULL) { this->set(&ds); }
~AutoRestoreStencil() { this->set(NULL); }
@@ -415,48 +423,6 @@ public:
GrProcessorDataManager* getProcessorDataManager() { return fProcDataManager.get(); }
const GrProcessorDataManager* processorDataManager() const { return fProcDataManager.get(); }
- /**
- * When this object is destroyed it will remove any additions to the GrProcessorDataManager
- * owned by the GrPipelineBuilder
- * This class can transiently modify its "const" GrPipelineBuilder object but will restore it
- * when done - so it is notionally "const" correct.
- */
- class AutoRestoreProcessorDataManager : public ::SkNoncopyable {
- public:
- AutoRestoreProcessorDataManager() : fPipelineBuilder(NULL), fSaveMarker(0) {}
-
- AutoRestoreProcessorDataManager(GrPipelineBuilder* ds)
- : fPipelineBuilder(NULL)
- , fSaveMarker(0) {
- this->set(ds);
- }
-
- ~AutoRestoreProcessorDataManager() { this->set(NULL); }
-
- void set(const GrPipelineBuilder* ds) {
- if (fPipelineBuilder) {
- fPipelineBuilder->getProcessorDataManager()->restoreToSaveMarker(/*fSaveMarker*/);
- }
- fPipelineBuilder = const_cast<GrPipelineBuilder*>(ds);
- if (ds) {
- fSaveMarker = ds->processorDataManager()->currentSaveMarker();
- }
- }
-
- bool isSet() const { return SkToBool(fPipelineBuilder); }
-
- GrProcessorDataManager* getProcessorDataManager() {
- SkASSERT(this->isSet());
- return fPipelineBuilder->getProcessorDataManager();
- }
-
- private:
- // notionally const (as marginalia)
- GrPipelineBuilder* fPipelineBuilder;
- uint32_t fSaveMarker;
- };
-
-
private:
// Calculating invariant color / coverage information is expensive, so we partially cache the
// results.

Powered by Google App Engine
This is Rietveld 408576698