Mandoline: Move ContentHandlerConnection into separate file

mojo/shell/application_manager.h

Index: mojo/shell/application_manager.h
diff --git a/mojo/shell/application_manager.h b/mojo/shell/application_manager.h
index 727b9e6e8c523abe187cd9a786da6d69bcf4c802..ed853ad9ba0d7323006bca885620ff5a1f6648da 100644
--- a/mojo/shell/application_manager.h
+++ b/mojo/shell/application_manager.h
@@ -31,6 +31,7 @@ class SequencedWorkerPool;
 namespace mojo {
 namespace shell {
 
+class ContentHandlerConnection;
 class ShellImpl;
 
 class ApplicationManager {
@@ -144,7 +145,7 @@ class ApplicationManager {
   void OnShellImplError(ShellImpl* shell_impl);
 
  private:
-  class ContentHandlerConnection;
+  friend class ContentHandlerConnection;

[jam, 2015/07/09 17:27:23]

now that it't not an inner class, the friend declaration seems dubious. just
make OnContentHandlerError public

[Fady Samuel, 2015/07/09 17:49:21]

Done.

 
   using ApplicationPackagedAlias = std::map<GURL, std::pair<GURL, std::string>>;
   using IdentityToShellImplMap = std::map<Identity, ShellImpl*>;
@@ -223,8 +224,9 @@ class ApplicationManager {
   // configured for the URL.
   ApplicationLoader* GetLoaderForURL(const GURL& url);
 
-  // Removes a ContentHandler when it encounters an error.
-  void OnContentHandlerError(ContentHandlerConnection* content_handler);
+  // Removes a ContentHandler when its connection is closed.
+  void OnContentHandlerConnectionClosed(
+      ContentHandlerConnection* content_handler);
 
   void CleanupRunner(NativeRunner* runner);