Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1228703004: Revert of Revert of GN: Explicitly list out public headers in the blink_headers source_set (Closed)

Created:
5 years, 5 months ago by agrieve
Modified:
5 years, 5 months ago
Reviewers:
Dirk Pranke, pdr., esprehn
CC:
esprehn, blink-reviews, brettw, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Revert of GN: Explicitly list out public headers in the blink_headers source_set (patchset #1 id:1 of https://codereview.chromium.org/1224843009/) Reason for revert: Re-landing now that https://crrev.com/deb02768bf9805279461259119a845aa2c734e25 is landed (fixes the gn check errors this introduced the first time around) Original issue's description: > Revert of GN: Explicitly list out public headers in the blink_headers source_set (patchset #2 id:20001 of https://codereview.chromium.org/1222673004/) > > Reason for revert: > This patch is causing build failures: > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/107230/steps/gn_check%20%28with%20patch%29/logs/stdio > > Original issue's description: > > GN: Explicitly list out public headers in the blink_headers source_set > > > > This enables "gn check" to enforce that source files that #include > > these headers also declare a dependency on them in GN. > > > > This also fixes "gn check" on Android from having errors like: > > > > ERROR at //components/autofill/content/renderer/autofill_agent.cc:45:11: Include not allowed. > > ^-------------------------------------------- > > It is not in any dependency of > > //components/autofill/content/renderer:renderer > > The include file is in the target(s): > > //third_party/WebKit/public:blink_headers_java_enums_srcjar__generate_enum > > which should somehow be reachable. > > > > BUG=367595 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198439 > > TBR=dpranke@chromium.org,esprehn@chromium.org,agrieve@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=367595 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198520 TBR=dpranke@chromium.org,esprehn@chromium.org,pdr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=367595 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198544

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+509 lines, -0 lines) Patch
M public/BUILD.gn View 1 chunk +509 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
agrieve
Created Revert of Revert of GN: Explicitly list out public headers in the blink_headers source_set
5 years, 5 months ago (2015-07-08 22:32:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228703004/1
5 years, 5 months ago (2015-07-08 22:33:07 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 5 months ago (2015-07-08 22:33:18 UTC) #4
Dirk Pranke
lgtm
5 years, 5 months ago (2015-07-08 23:32:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228703004/1
5 years, 5 months ago (2015-07-08 23:32:58 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=198544
5 years, 5 months ago (2015-07-08 23:33:25 UTC) #8
pdr.
On 2015/07/08 at 23:33:25, commit-bot wrote: > Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=198544 Oh no, ...
5 years, 5 months ago (2015-07-08 23:34:17 UTC) #9
Dirk Pranke
On 2015/07/08 23:34:17, pdr wrote: > On 2015/07/08 at 23:33:25, commit-bot wrote: > > Committed ...
5 years, 5 months ago (2015-07-08 23:40:10 UTC) #10
agrieve
5 years, 5 months ago (2015-07-09 00:05:01 UTC) #11
Message was sent while issue was closed.
On 2015/07/08 23:40:10, Dirk Pranke wrote:
> On 2015/07/08 23:34:17, pdr wrote:
> > On 2015/07/08 at 23:33:25, commit-bot wrote:
> > > Committed patchset #1 (id:1) as
> > https://src.chromium.org/viewvc/blink?view=rev&revision=198544
> > 
> > Oh no, this should have been put through the CQ. Alas, lets keep an eye on
the
> > bots.
> 
> Yeah, I tried to use the CQ but didn't realize that we had NOPRESUBMIT et. al.
> :(.

Whoops! Sorry to set you up like that :S. Just clicked the "Revert Patchset"
button and didn't realize it would have such side-effects. I'm around for the
next couple of hours anyways, so will keep an eye on
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...

Powered by Google App Engine
This is Rietveld 408576698