Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 12286020: Replace FilePath with base::FilePath. (Closed)

Created:
7 years, 10 months ago by brettw
Modified:
7 years, 10 months ago
Reviewers:
sky, Wez
CC:
chromium-reviews, kkania, rpetterson, yurys, kinuko+watch, dcaiafa+watch_chromium.org, cbentzel+watch_chromium.org, vsevik, benjhayden+dwatch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, tzik+watch_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, amit, wez+watch_chromium.org, sanjeevr, rouslan+spellwatch_chromium.org, simonmorris+watch_chromium.org, feature-media-reviews_chromium.org, pam+watch_chromium.org, sergeyu+watch_chromium.org, jochen+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, achuith+watch_chromium.org, sail+watch_chromium.org, garykac+watch_chromium.org, Aaron Boodman, lambroslambrou+watch_chromium.org, jshin+watch_chromium.org, rdsmith+dwatch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, pfeldman
Visibility:
Public.

Description

Replace FilePath with base::FilePath. This is im preparation for removing the 'using" in file_path.h Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+516 lines, -470 lines) Patch
M base/command_line_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/file_path_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M base/file_util_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/i18n/file_util_icu.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M base/path_service_unittest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M base/perftimer.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/platform_file_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/prefs/json_pref_store.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M base/prefs/json_pref_store_unittest.cc View 10 chunks +15 lines, -15 lines 0 comments Download
M base/prefs/public/pref_member.h View 3 chunks +9 lines, -7 lines 0 comments Download
M base/prefs/public/pref_member.cc View 7 chunks +15 lines, -11 lines 0 comments Download
M base/process_util_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/sys_info_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/test/scoped_path_override.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_file_util_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_file_util_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_file_util_posix.cc View 8 chunks +17 lines, -16 lines 0 comments Download
M base/test/test_file_util_win.cc View 11 chunks +20 lines, -19 lines 0 comments Download
M base/test/test_shortcut_win.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M base/test/test_suite.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/test/test_support_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/activity_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/managed_mode_private/managed_mode_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/media_galleries_eject_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google_apis/drive_api_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/drive_api_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/drive_service_interface.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/drive_uploader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/drive_uploader_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/google_apis/dummy_drive_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/dummy_drive_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/fake_drive_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/fake_drive_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/mock_drive_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/system_monitor/removable_storage_notifications_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/system_monitor/test_removable_storage_notifications.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/system_monitor/test_removable_storage_notifications.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/commands/chrome_commands.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/child_process_security_policy_unittest.cc View 1 chunk +13 lines, -11 lines 0 comments Download
M content/browser/download/file_metadata_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/save_package.cc View 20 chunks +55 lines, -51 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_flash_file_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/content_browser_client.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/public/browser/devtools_http_handler_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/download_item.h View 2 chunks +6 lines, -6 lines 0 comments Download
M content/public/browser/download_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/download_manager_delegate.h View 4 chunks +12 lines, -11 lines 0 comments Download
M content/public/browser/download_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/download_save_info.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/download_url_parameters.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/indexed_db_context.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/browser/plugin_service_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/storage_partition.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents.h View 1 chunk +6 lines, -5 lines 0 comments Download
M content/public/browser/web_contents_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents_observer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/common/content_constants.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/content_constants.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/file_chooser_params.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/pepper_plugin_info.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/browser_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/browser_test_utils.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/test/browser_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/mock_download_item.h View 2 chunks +6 lines, -6 lines 0 comments Download
M content/public/test/mock_download_manager.h View 3 chunks +6 lines, -6 lines 0 comments Download
M content/public/test/mock_download_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/public/test/render_widget_test.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/test/render_widget_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/test_browser_context.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/test/test_browser_context.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/public/test/test_file_error_injector.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M content/public/test/test_launcher.cc View 2 chunks +10 lines, -9 lines 0 comments Download
M content/renderer/gpu/gpu_benchmarking_extension.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/hyphenator/hyphenator_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_file_chooser_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_file_chooser_host_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_file_io_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_hung_plugin_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_hung_plugin_filter.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M content/renderer/pepper/renderer_ppapi_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.h View 4 chunks +8 lines, -6 lines 0 comments Download
M content/renderer/render_view_impl.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/android/browsertests_apk/content_browser_tests_android.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/shell/paths_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_browser_context.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/test_data_util.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/test_data_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/file_data_source_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/gdig/gdig.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/flash_file_resource.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M ppapi/shared_impl/file_path.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/backend/print_backend_cups.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/resources.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/authenticator_test_base.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/protocol/ssl_hmac_channel_authenticator_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/leveldatabase/env_chromium.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M ui/base/resource/resource_bundle.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/resource/resource_bundle.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/resource/resource_bundle_aurax11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/resource/resource_bundle_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/resource/resource_bundle_ios.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/base/resource/resource_bundle_mac.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/base/resource/resource_bundle_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/shell_dialogs/gtk/select_file_dialog_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/blob/blob_storage_controller_unittest.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M webkit/database/database_quota_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/file_system_util.h View 2 chunks +6 lines, -5 lines 0 comments Download
M webkit/fileapi/file_system_util.cc View 2 chunks +10 lines, -9 lines 0 comments Download
M webkit/fileapi/file_system_util_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/fileapi/isolated_file_util_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M webkit/fileapi/local_file_system_cross_operation_unittest.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M webkit/fileapi/media/device_media_async_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/native_file_util_unittest.cc View 13 chunks +28 lines, -27 lines 0 comments Download
M webkit/fileapi/obfuscated_file_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/plugin_instance.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_lib_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/simple_dom_storage_system.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
TBR=sky
7 years, 10 months ago (2013-02-17 05:06:10 UTC) #1
Wez
7 years, 10 months ago (2013-02-17 06:55:28 UTC) #2
Message was sent while issue was closed.
remoting/ LGTM

Powered by Google App Engine
This is Rietveld 408576698