Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Side by Side Diff: gyp/common_conditions.gypi

Issue 1228553010: Remove skia_arch_width, fold into skia_arch_type. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 Google Inc. 1 # Copyright 2015 Google Inc.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 # conditions used in both common.gypi and skia.gyp in chromium 6 # conditions used in both common.gypi and skia.gyp in chromium
7 # 7 #
8 { 8 {
9 'defines': [ 9 'defines': [
10 'SK_ALLOW_STATIC_GLOBAL_INITIALIZERS=<(skia_static_initializers)', 10 'SK_ALLOW_STATIC_GLOBAL_INITIALIZERS=<(skia_static_initializers)',
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 'inherit_from': ['Release_Developer'], 154 'inherit_from': ['Release_Developer'],
155 'msvs_settings': { 155 'msvs_settings': {
156 'VCCLCompilerTool': { 156 'VCCLCompilerTool': {
157 # Don't specify /arch. SSE2 is implied by 64bit and specify ing it warns. 157 # Don't specify /arch. SSE2 is implied by 64bit and specify ing it warns.
158 'EnableEnhancedInstructionSet': '0', # 158 'EnableEnhancedInstructionSet': '0', #
159 }, 159 },
160 }, 160 },
161 }, 161 },
162 }, 162 },
163 }], 163 }],
164 [ 'skia_arch_width == 64', { 164 [ 'skia_arch_type == "x86_64"', {
165 'msvs_configuration_platform': 'x64', 165 'msvs_configuration_platform': 'x64',
166 }], 166 }],
167 [ 'skia_arch_width == 32', { 167 [ 'skia_arch_type == "x86"', {
168 'msvs_configuration_platform': 'Win32', 168 'msvs_configuration_platform': 'Win32',
169 }], 169 }],
170 [ 'skia_warnings_as_errors', { 170 [ 'skia_warnings_as_errors', {
171 'msvs_settings': { 171 'msvs_settings': {
172 'VCCLCompilerTool': { 172 'VCCLCompilerTool': {
173 'WarnAsError': 'true', 173 'WarnAsError': 'true',
174 'AdditionalOptions': [ 174 'AdditionalOptions': [
175 '/we4189', # initialized but unused var warning 175 '/we4189', # initialized but unused var warning
176 ], 176 ],
177 }, 177 },
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
287 'SK_ARM_HAS_OPTIONAL_NEON', 287 'SK_ARM_HAS_OPTIONAL_NEON',
288 ], 288 ],
289 }], 289 }],
290 [ 'skia_os != "chromeos" and skia_os != "linux"', { 290 [ 'skia_os != "chromeos" and skia_os != "linux"', {
291 'cflags': [ 291 'cflags': [
292 '-mfloat-abi=softfp', 292 '-mfloat-abi=softfp',
293 ], 293 ],
294 }], 294 }],
295 ], 295 ],
296 }], 296 }],
297 [ 'skia_arch_type == "mips"', { 297 [ '"mips" in skia_arch_type', {
298 'cflags': [ 298 'cflags': [
299 '-EL', 299 '-EL',
300 ], 300 ],
301 'conditions': [ 301 'conditions': [
302 [ 'mips_arch_variant == "mips32r2"', { 302 [ 'mips_arch_variant == "mips32r2"', {
303 'cflags': [ 303 'cflags': [
304 '-march=mips32r2', 304 '-march=mips32r2',
305 ], 305 ],
306 'conditions': [ 306 'conditions': [
307 [ 'mips_dsp == 1', { 307 [ 'mips_dsp == 1', {
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
488 }, 488 },
489 'Release': { 489 'Release': {
490 'xcode_settings': { 'GCC_OPTIMIZATION_LEVEL': '<(skia_release_optimi zation_level)', }, 490 'xcode_settings': { 'GCC_OPTIMIZATION_LEVEL': '<(skia_release_optimi zation_level)', },
491 'defines': [ 'NDEBUG' ], 491 'defines': [ 'NDEBUG' ],
492 }, 492 },
493 }, 493 },
494 'xcode_settings': { 494 'xcode_settings': {
495 'conditions': [ 495 'conditions': [
496 [ 'skia_fast', { 'WARNING_CFLAGS': [ '<@(skia_fast_flags)' ] } ], 496 [ 'skia_fast', { 'WARNING_CFLAGS': [ '<@(skia_fast_flags)' ] } ],
497 [ 'skia_warnings_as_errors', { 'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES' }], 497 [ 'skia_warnings_as_errors', { 'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES' }],
498 [ 'skia_arch_width == 32', { 'ARCHS': ['i386'] }], 498 [ 'skia_arch_type == "x86"', { 'ARCHS': ['i386'] }],
499 [ 'skia_arch_width == 64', { 'ARCHS': ['x86_64'] }], 499 [ 'skia_arch_type == "x86_64"', { 'ARCHS': ['x86_64'] }],
500 [ 'skia_osx_deployment_target==""', { 500 [ 'skia_osx_deployment_target==""', {
501 'MACOSX_DEPLOYMENT_TARGET': '10.6', # -mmacos-version-min, passed in env to ld. 501 'MACOSX_DEPLOYMENT_TARGET': '10.6', # -mmacos-version-min, passed in env to ld.
502 }, { 502 }, {
503 'MACOSX_DEPLOYMENT_TARGET': '<(skia_osx_deployment_target)', 503 'MACOSX_DEPLOYMENT_TARGET': '<(skia_osx_deployment_target)',
504 }], 504 }],
505 ], 505 ],
506 'CLANG_CXX_LANGUAGE_STANDARD': 'c++11', 506 'CLANG_CXX_LANGUAGE_STANDARD': 'c++11',
507 'GCC_ENABLE_SUPPLEMENTAL_SSE3_INSTRUCTIONS': 'YES', # -mssse3 507 'GCC_ENABLE_SUPPLEMENTAL_SSE3_INSTRUCTIONS': 'YES', # -mssse3
508 'GCC_SYMBOLS_PRIVATE_EXTERN': 'NO', # -fvisibility=hi dden 508 'GCC_SYMBOLS_PRIVATE_EXTERN': 'NO', # -fvisibility=hi dden
509 'GCC_INLINES_ARE_PRIVATE_EXTERN': 'NO', # -fvisibility-in lines-hidden 509 'GCC_INLINES_ARE_PRIVATE_EXTERN': 'NO', # -fvisibility-in lines-hidden
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
627 # add flags here (e.g. SK_SUPPORT_LEGACY_...) needed by moz2d 627 # add flags here (e.g. SK_SUPPORT_LEGACY_...) needed by moz2d
628 ], 628 ],
629 }], 629 }],
630 630
631 ], # end 'conditions' 631 ], # end 'conditions'
632 # The Xcode SYMROOT must be at the root. See build/common.gypi in chromium for more details 632 # The Xcode SYMROOT must be at the root. See build/common.gypi in chromium for more details
633 'xcode_settings': { 633 'xcode_settings': {
634 'SYMROOT': '<(DEPTH)/xcodebuild', 634 'SYMROOT': '<(DEPTH)/xcodebuild',
635 }, 635 },
636 } 636 }
OLDNEW
« no previous file with comments | « gyp/common.gypi ('k') | gyp/common_variables.gypi » ('j') | gyp/everything.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698