Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chromeos/network/onc/onc_translation_tables.cc

Issue 1228543002: Translate ONC ProxySettings <-> Shill ProxyConfig (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use net/ parsing, update OWNERS Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chromeos/chromeos.gyp ('K') | « chromeos/network/DEPS ('k') | chromeos/network/onc/onc_translator_onc_to_shill.cc » ('j') | chromeos/network/onc/onc_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/onc/onc_translation_tables.cc
diff --git a/chromeos/network/onc/onc_translation_tables.cc b/chromeos/network/onc/onc_translation_tables.cc
index 40e0cd177019cdda6f99a88599d0b50c59b09bfd..a71f4414e51c28ed69797a5cd01d08677c15aee4 100644
--- a/chromeos/network/onc/onc_translation_tables.cc
+++ b/chromeos/network/onc/onc_translation_tables.cc
@@ -15,9 +15,6 @@ namespace onc {
// CertificatePattern is converted with function CreateUIData(...) to UIData
// stored in Shill.
-//
-// Proxy settings are converted to Shill by function
-// ConvertOncProxySettingsToProxyConfig(...).
namespace {
@@ -198,6 +195,7 @@ const FieldTranslationEntry network_fields[] = {
// Type is converted during translation, see onc_translator_*.
// {::onc::network_config::kType, shill::kTypeProperty },
+ // {::onc::network_config::kProxySettings, shill::ProxyConfig},
// These fields are converted during translation, see
// onc_translator_shill_to_onc.cc. They are only converted when going from
« chromeos/chromeos.gyp ('K') | « chromeos/network/DEPS ('k') | chromeos/network/onc/onc_translator_onc_to_shill.cc » ('j') | chromeos/network/onc/onc_utils.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698