Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Unified Diff: utils/tests/pub/install/path/absolute_symlink_test.dart

Issue 12285010: Support relative paths in path dependencies. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Tweak some comments. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/pub/source.dart ('k') | utils/tests/pub/install/path/relative_path_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/tests/pub/install/path/absolute_symlink_test.dart
diff --git a/utils/tests/pub/install/path/absolute_path_test.dart b/utils/tests/pub/install/path/absolute_symlink_test.dart
similarity index 56%
copy from utils/tests/pub/install/path/absolute_path_test.dart
copy to utils/tests/pub/install/path/absolute_symlink_test.dart
index cef0a760b07a95788a5b70111968d06c285b47bb..37aec85eca3fdc368e3d77bba0bda89566c6521d 100644
--- a/utils/tests/pub/install/path/absolute_path_test.dart
+++ b/utils/tests/pub/install/path/absolute_symlink_test.dart
@@ -4,14 +4,16 @@
import '../../../../../pkg/path/lib/path.dart' as path;
+import '../../../../pub/exit_codes.dart' as exit_codes;
import '../../test_pub.dart';
main() {
initConfig();
- integration('path dependency with absolute path', () {
- dir('foo', [
- libDir('foo'),
- libPubspec('foo', '0.0.1')
+ integration("generates a symlink with an absolute path if the dependency "
+ "path was absolute", () {
+ dir("foo", [
+ libDir("foo"),
+ libPubspec("foo", "0.0.1")
]).scheduleCreate();
dir(appPath, [
@@ -26,20 +28,17 @@ main() {
schedulePub(args: ["install"],
output: new RegExp(r"Dependencies installed!$"));
- dir(packagesPath, [
- dir("foo", [
- file("foo.dart", 'main() => "foo";')
- ])
- ]).scheduleValidate();
-
- // Move the packages directory and ensure the symlink still works. That
- // will validate that we actually created an absolute symlink.
dir("moved").scheduleCreate();
- scheduleRename(packagesPath, "moved/packages");
- dir("moved/packages", [
- dir("foo", [
- file("foo.dart", 'main() => "foo";')
+ // Move the app but not the package. Since the symlink is absolute, it
+ // should still be able to find it.
+ scheduleRename(appPath, path.join("moved", appPath));
+
+ dir("moved", [
+ dir(packagesPath, [
+ dir("foo", [
+ file("foo.dart", 'main() => "foo";')
+ ])
])
]).scheduleValidate();
});
« no previous file with comments | « utils/pub/source.dart ('k') | utils/tests/pub/install/path/relative_path_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698