Support relative paths in path dependencies.

utils/pub/git_source.dart

Index: utils/pub/git_source.dart
diff --git a/utils/pub/git_source.dart b/utils/pub/git_source.dart
index fdb0ed4828c8e9ebcc35ea2ebceadab57f4136ed..fd469d28581bed8a98b35f47b46a07679ff774b7 100644
--- a/utils/pub/git_source.dart
+++ b/utils/pub/git_source.dart
@@ -10,6 +10,7 @@ import '../../pkg/path/lib/path.dart' as path;
 
 import 'git.dart' as git;
 import 'io.dart';
+import 'log.dart' as log;
 import 'package.dart';
 import 'source.dart';
 import 'source_registry.dart';
@@ -67,24 +68,30 @@ class GitSource extends Source {
       return path.join(systemCacheRoot, revisionCacheName);
     });
   }
+
   /// Ensures [description] is a Git URL.
-  void validateDescription(description, {bool fromLockFile: false}) {
+  dynamic parseDescription(String containingPath, description,
+                           {bool fromLockFile: false}) {
+    // TODO(rnystrom): Handle git URLs that are relative file paths.

[nweiz, 2013/02/15 23:09:24]

Add a bug number. Also, it would be nice if we could detect this and throw a
useful error.

[Bob Nystrom, 2013/02/16 00:09:57]

Added a bug. I don't want to add any code here unless I also add tests, and
that's a bit out of scope for this change.

     // A single string is assumed to be a Git URL.
-    if (description is String) return;
+    if (description is String) return description;

[nweiz, 2013/02/15 23:09:24]

It would make other code nicer if we canonicalized the format here by returning
{'url': description, 'ref': null}.

[Bob Nystrom, 2013/02/16 00:09:57]

Added a TODO.

     if (description is! Map || !description.containsKey('url')) {
       throw new FormatException("The description must be a Git URL or a map "
           "with a 'url' key.");
     }
-    description = new Map.from(description);
-    description.remove('url');
-    description.remove('ref');
-    if (fromLockFile) description.remove('resolved-ref');
-
-    if (!description.isEmpty) {
-      var plural = description.length > 1;
-      var keys = description.keys.join(', ');
+
+    var parsed = new Map.from(description);
+    parsed.remove('url');
+    parsed.remove('ref');
+    if (fromLockFile) parsed.remove('resolved-ref');
+
+    if (!parsed.isEmpty) {
+      var plural = parsed.length > 1;
+      var keys = parsed.keys.join(', ');
       throw new FormatException("Invalid key${plural ? 's' : ''}: $keys.");
     }
+
+    return description;
   }
 
   /// Two Git descriptions are equal if both their URLs and their refs are