Support relative paths in path dependencies.

utils/pub/path_source.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library path_source;
 
 import 'dart:async';
 import 'dart:io';
 
 import '../../pkg/path/lib/path.dart' as path;
@@ skipping 11 matching lines @@
   final name = 'path';
   final shouldCache = false;
 
   Future<Pubspec> describe(PackageId id) {
     return defer(() {
       _validatePath(id.name, id.description);
       return new Pubspec.load(id.name, id.description, systemCache.sources);
     });
   }
 
-  Future<bool> install(PackageId id, String path) {
+  Future<bool> install(PackageId id, String destination) {
     return defer(() {
       try {
         _validatePath(id.name, id.description);
       } on FormatException catch(err) {
         return false;
       }
-      return createPackageSymlink(id.name, id.description, path);
+
+      return createPackageSymlink(id.name, destination, id.description,
+          relative: true);

[nweiz, 2013/02/15 23:09:24]

This should be relative iff the path the user specified was relative.

[Bob Nystrom, 2013/02/16 00:09:57]

Done.

     }).then((_) => true);
   }
 
-  void validateDescription(description, {bool fromLockFile: false}) {
+  dynamic parseDescription(String containingPath, description,
+                           {bool fromLockFile: false}) {
     if (description is! String) {
       throw new FormatException("The description must be a path string.");
     }
+
+    if (path.isRelative(description)) {
+      // Can't handle relative paths coming from pubspecs that are not on the
+      // local file system.

[nweiz, 2013/02/15 23:09:24]

Can this ever happen in practice? If so, we should throw a more useful error
here.

[Bob Nystrom, 2013/02/16 00:09:57]

If a hosted package had a path dependency (which is specifically a validation
error) you would hit this path. I don't think it will occur in practice, though
pub the client app itself doesn't currently ensure this.

[nweiz, 2013/02/16 01:02:14]

What if a remote git dependency has a path dependency?

[Bob Nystrom, 2013/02/16 01:19:03]

I believe that will get installed locally, and then it'll resolve the path dep
from there.

[nweiz, 2013/02/16 01:33:11]

That sounds like something else we should throw a meaningful error for.

+      assert(containingPath != null);
+      description = path.join(path.dirname(containingPath), description);
+    }
+
+    return description;
   }
 
   /// Ensures that [dir] is a valid path. It must be an absolute path that
   /// points to an existing directory. Throws a [FormatException] if the path
   /// is invalid.
   void _validatePath(String name, String dir) {
     // Relative paths are not (currently) allowed because the user would expect
     // them to be relative to the pubspec where the dependency appears. That in
     // turn means that two pubspecs in different locations with the same
     // relative path dependency could refer to two different packages. That
@@ skipping 12 matching lines @@
       throw new FormatException(
           "Path dependency for package '$name' must refer to a "
           "directory, not a file. Was '$dir'.");
     }
 
     if (!dirExists(dir)) {
       throw new FormatException("Could not find package '$name' at '$dir'.");
     }
   }
 }