Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: pkg/analyzer/lib/src/generated/source.dart

Issue 1228493003: Revert "Package map source factory support" [TBR]. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/generated/source.dart
diff --git a/pkg/analyzer/lib/src/generated/source.dart b/pkg/analyzer/lib/src/generated/source.dart
index 6ab440580566bfb4a98e4fbe178240a0beb7575d..4900cf687fd5f68a6be3a52acc51f9d5c249b6d0 100644
--- a/pkg/analyzer/lib/src/generated/source.dart
+++ b/pkg/analyzer/lib/src/generated/source.dart
@@ -11,11 +11,8 @@ import 'dart:collection';
import "dart:math" as math;
import 'package:analyzer/file_system/file_system.dart';
-import 'package:analyzer/file_system/physical_file_system.dart';
import 'package:analyzer/source/package_map_resolver.dart';
-import 'package:analyzer/src/generated/utilities_dart.dart' as utils;
import 'package:analyzer/task/model.dart';
-import 'package:package_config/packages.dart';
import 'package:path/path.dart' as pathos;
import 'engine.dart';
@@ -578,17 +575,6 @@ class SourceFactory {
AnalysisContext context;
/**
- * URI processor used to find mappings for `package:` URIs found in a `.packages` config
- * file.
- */
- final Packages _packages;
-
- /**
- * Resource provider used in working with package maps.
- */
- final ResourceProvider _resourceProvider;
-
- /**
* The resolvers used to resolve absolute URI's.
*/
final List<UriResolver> _resolvers;
@@ -599,14 +585,11 @@ class SourceFactory {
LocalSourcePredicate _localSourcePredicate = LocalSourcePredicate.NOT_SDK;
/**
- * Initialize a newly created source factory with the given absolute URI [resolvers] and
- * optional [packages] resolution helper.
+ * Initialize a newly created source factory.
+ *
+ * @param resolvers the resolvers used to resolve absolute URI's
*/
- SourceFactory(this._resolvers,
- [this._packages = Packages.noPackages, ResourceProvider resourceProvider])
- : _resourceProvider = resourceProvider != null
- ? resourceProvider
- : PhysicalResourceProvider.INSTANCE;
+ SourceFactory(this._resolvers);
/**
* Return the [DartSdk] associated with this [SourceFactory], or `null` if there
@@ -637,19 +620,6 @@ class SourceFactory {
/// A table mapping package names to paths of directories containing
/// the package (or [null] if there is no registered package URI resolver).
Map<String, List<Folder>> get packageMap {
- // Start by looking in .packages.
- if (_packages != Packages.noPackages) {
- Map<String, List<Folder>> packageMap = <String, List<Folder>>{};
- _packages.asMap().forEach((String name, Uri uri) {
- if (uri.scheme == 'file' || uri.scheme == '' /* unspecified */) {
- packageMap[name] =
- <Folder>[_resourceProvider.getFolder(uri.toFilePath())];
- }
- });
- return packageMap;
- }
-
- // Default to the PackageMapUriResolver.
PackageMapUriResolver resolver = _resolvers.firstWhere(
(r) => r is PackageMapUriResolver, orElse: () => null);
return resolver != null ? resolver.packageMap : null;
@@ -757,41 +727,15 @@ class SourceFactory {
* @return the absolute URI representing the given source
*/
Uri restoreUri(Source source) {
- // First see if a resolver can restore the URI.
for (UriResolver resolver in _resolvers) {
Uri uri = resolver.restoreAbsolute(source);
if (uri != null) {
- // Now see if there's a package mapping.
- Uri packageMappedUri = _getPackageMapping(uri);
- if (packageMappedUri != null) {
- return packageMappedUri;
- }
- // Fall back to the resolver's computed URI.
return uri;
}
}
-
return null;
}
- Uri _getPackageMapping(Uri sourceUri) {
- if (sourceUri.scheme != 'file') {
- //TODO(pquitslund): verify this works for non-file URIs.
- return null;
- }
-
- Uri packageUri;
- _packages.asMap().forEach((String name, Uri uri) {
- if (packageUri == null) {
- if (utils.startsWith(sourceUri, uri)) {
- packageUri = Uri.parse(
- 'package:$name/${sourceUri.path.substring(uri.path.length)}');
- }
- }
- });
- return packageUri;
- }
-
/**
* Return a source object representing the URI that results from resolving the given (possibly
* relative) contained URI against the URI associated with an existing source object, or
@@ -811,15 +755,6 @@ class SourceFactory {
}
containedUri = containingSource.resolveRelativeUri(containedUri);
}
- // Now check .packages.
- if (containedUri.scheme == 'package') {
- Uri packageUri =
- _packages.resolve(containedUri, notFound: (Uri packageUri) => null);
- //TODO(pquitslund): package_config needs to be updated to set schemes for file URIs.
- if (packageUri != null && packageUri.scheme == '') {
- containedUri = new Uri.file(packageUri.toFilePath());
- }
- }
for (UriResolver resolver in _resolvers) {
Source result = resolver.resolveAbsolute(containedUri);
if (result != null) {
« no previous file with comments | « pkg/analyzer/lib/file_system/physical_file_system.dart ('k') | pkg/analyzer/lib/src/generated/source_io.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698