Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 1228463003: X87: [turbofan] Enable tail calls for %_CallRuntime. (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Enable tail calls for %_CallRuntime. port 1fa4285e1ce16cfadf8c40a0993491ec4e2bbbe0 (r29436). original commit message: This involves: - Enabling the tail call optimization reducer in all cases. - Adding an addition flag to CallFunctionParameters to mark call sites that can be tail-called enabled. - Only set the tail-call flag for %_CallFunction. BUG= R=weiliang.lin@intel.com Committed: https://chromium.googlesource.com/v8/v8/+/19e53974c46d41f73f61636be2397b3bc6725375

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -14 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
chunyang.dai
PTAL.
5 years, 5 months ago (2015-07-06 02:31:11 UTC) #2
Weiliang
lgtm
5 years, 5 months ago (2015-07-06 03:09:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228463003/1
5 years, 5 months ago (2015-07-06 03:09:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/7404)
5 years, 5 months ago (2015-07-06 03:33:04 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/19e53974c46d41f73f61636be2397b3bc6725375 Cr-Commit-Position: refs/heads/master@{#29504}
5 years, 5 months ago (2015-07-07 01:06:01 UTC) #8
chunyang.dai
5 years, 5 months ago (2015-07-07 01:06:06 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
19e53974c46d41f73f61636be2397b3bc6725375 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698