Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 12284013: Shrink texture uploader when not visible. (Closed)

Created:
7 years, 10 months ago by piman
Modified:
7 years, 10 months ago
Reviewers:
reveman
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Shrink texture uploader when not visible. Together with https://codereview.chromium.org/12278025/ this helps freeing the shared memory associated with queries when renderers go to the background. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183006

Patch Set 1 #

Patch Set 2 : rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M cc/gl_renderer.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/resource_provider.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/resource_provider.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M cc/texture_uploader.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/texture_uploader.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
piman
7 years, 10 months ago (2013-02-16 01:58:31 UTC) #1
reveman
lgtm but maybe use a more descriptive term than shrink. TextureUploader::releaseCachedQueries and ResourceProvider::releaseCachedData?
7 years, 10 months ago (2013-02-16 02:59:40 UTC) #2
piman
On 2013/02/16 02:59:40, David Reveman wrote: > lgtm but maybe use a more descriptive term ...
7 years, 10 months ago (2013-02-16 03:15:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/12284013/4001
7 years, 10 months ago (2013-02-16 03:58:40 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=85201
7 years, 10 months ago (2013-02-16 17:24:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/12284013/4001
7 years, 10 months ago (2013-02-16 21:15:31 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-16 22:20:06 UTC) #7
Message was sent while issue was closed.
Change committed as 183006

Powered by Google App Engine
This is Rietveld 408576698