compute convexity for very small paths

Very tiny paths are subsumed by the Convexicator
and are treated as convex when they are not.

Allow the SkPath::Iter to leave degenerate path
segments unmolested by passing an additional exact
bool to next().

Treat any non-zero length as significant in addPt().

R=reed@google.com,robertphillips@google.com
BUG=493450
Committed: https://skia.googlesource.com/skia/+/e8c5666e0387e70bd921e01558e627af3f1411db

[caryclark, 2015-07-10 16:06:07]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-07-10 16:06:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1228383002/20001

[commit-bot: I haz the power, 2015-07-10 16:13:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-10 16:13:42]

Dry run: This issue passed the CQ dry run.

[caryclark, 2015-07-10 16:31:39]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-07-10 16:31:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1228383002/40001

[commit-bot: I haz the power, 2015-07-10 16:54:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-10 16:54:41]

Dry run: This issue passed the CQ dry run.

[caryclark, 2015-07-13 12:13:00]

caryclark@google.com changed reviewers:
+ reed@google.com, robertphillips@google.com

[robertphillips, 2015-07-13 17:49:12]

lgtm but since I'm sure I don't understand all the implications I would prefer
Mike to have a look too.

https://codereview.chromium.org/1228383002/diff/40001/include/core/SkPath.h
File include/core/SkPath.h (right):

https://codereview.chromium.org/1228383002/diff/40001/include/core/SkPath.h#n...
include/core/SkPath.h:802: deemed degenerate (too short) and skip those.
@param exact if true perform exact comparison ...
?

[caryclark, 2015-07-13 18:23:42]

https://codereview.chromium.org/1228383002/diff/40001/include/core/SkPath.h
File include/core/SkPath.h (right):

https://codereview.chromium.org/1228383002/diff/40001/include/core/SkPath.h#n...
include/core/SkPath.h:802: deemed degenerate (too short) and skip those.
On 2015/07/13 17:49:11, robertphillips wrote:
> @param exact if true perform exact comparison ...
> ?

Done. Good catch -- I forgot about updating the documentation.

[reed1, 2015-07-14 15:14:37]

Maybe its time to pull in those predicate functions into private...

lgtm

[reed1, 2015-07-14 15:15:22]

nit: an enum ( Tolerance, Exact ) or something like it might make the call-sites
easier to read, than true/false.

[caryclark, 2015-07-14 17:58:06]

The CQ bit was checked by caryclark@google.com

[caryclark, 2015-07-14 17:58:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1228383002/#ps60001
(title: "fix path documentation")

[commit-bot: I haz the power, 2015-07-14 17:58:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1228383002/60001

[commit-bot: I haz the power, 2015-07-14 18:19:30]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/e8c5666e0387e70bd921e01558e627af3f1411db