Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: src/variables.cc

Issue 1228373011: Fix broken Variable::IsGlobalObjectProperty() after https://codereview.chromium.org/1218783005 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/ast.h" 7 #include "src/ast.h"
8 #include "src/scopes.h" 8 #include "src/scopes.h"
9 #include "src/variables.h" 9 #include "src/variables.h"
10 10
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 initialization_flag_(initialization_flag), 51 initialization_flag_(initialization_flag),
52 maybe_assigned_(maybe_assigned_flag) { 52 maybe_assigned_(maybe_assigned_flag) {
53 // Var declared variables never need initialization. 53 // Var declared variables never need initialization.
54 DCHECK(!(mode == VAR && initialization_flag == kNeedsInitialization)); 54 DCHECK(!(mode == VAR && initialization_flag == kNeedsInitialization));
55 } 55 }
56 56
57 57
58 bool Variable::IsGlobalObjectProperty() const { 58 bool Variable::IsGlobalObjectProperty() const {
59 // Temporaries are never global, they must always be allocated in the 59 // Temporaries are never global, they must always be allocated in the
60 // activation frame. 60 // activation frame.
61 return IsDynamicVariableMode(mode_) || IsStaticGlobalObjectProperty(); 61 return (IsDynamicVariableMode(mode_) ||
62 (IsDeclaredVariableMode(mode_) && !IsLexicalVariableMode(mode_))) &&
63 scope_ != NULL && scope_->is_script_scope() && !is_this();
62 } 64 }
63 65
64 66
65 bool Variable::IsStaticGlobalObjectProperty() const { 67 bool Variable::IsStaticGlobalObjectProperty() const {
66 // Temporaries are never global, they must always be allocated in the 68 // Temporaries are never global, they must always be allocated in the
67 // activation frame. 69 // activation frame.
68 return (IsDeclaredVariableMode(mode_) && !IsLexicalVariableMode(mode_)) && 70 return (IsDeclaredVariableMode(mode_) && !IsLexicalVariableMode(mode_)) &&
69 scope_ != NULL && scope_->is_script_scope() && !is_this(); 71 scope_ != NULL && scope_->is_script_scope() && !is_this();
70 } 72 }
71 73
72 74
73 int Variable::CompareIndex(Variable* const* v, Variable* const* w) { 75 int Variable::CompareIndex(Variable* const* v, Variable* const* w) {
74 int x = (*v)->index(); 76 int x = (*v)->index();
75 int y = (*w)->index(); 77 int y = (*w)->index();
76 // Consider sorting them according to type as well? 78 // Consider sorting them according to type as well?
77 return x - y; 79 return x - y;
78 } 80 }
79 81
80 } // namespace internal 82 } // namespace internal
81 } // namespace v8 83 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698