LayoutTests/fast/table/table-different-overflow-values.html - Issue 1228373007: Compute the correct overflow-x and overflow-y values for table elements

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/table/table-different-overflow-values.html

Issue 1228373007: Compute the correct overflow-x and overflow-y values for table elements (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/fast/table/overflowScroll.html ('K') | « LayoutTests/fast/table/overflowScroll-expected.html ('k') | LayoutTests/fast/table/table-different-overflow-values-expected.txt » ('j') | Source/core/css/resolver/StyleAdjuster.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/js-test.js"></script>

	3 <!-- For tables. -->

	4 <table id="table1" class="test" style="overflow-x: visible; overflow-y: auto"/>

	5 <table id="table2" class="test" style="overflow-x: visible; overflow-y: scroll"/ >

	6 <table id="table3" class="test" style="overflow-x: visible; overflow-y: hidden"/ >

	7 <!-- For inline tables. -->

	8 <table id="inline_table1" class="test" style="overflow-x: visible; overflow-y: a uto; display: inline"/>

	9 <table id="inline_table2" class="test" style="overflow-x: visible; overflow-y: s croll; display: inline"/>

	10 <table id="inline_table3" class="test" style="overflow-x: visible; overflow-y: h idden; display: inline"/>

	11 <!-- For table row groups. -->

	12 <table>

	13 <tbody id="tbody1" class="test" style="overflow-x: visible; overflow-y: auto "/>

	14 <tbody id="tbody2" class="test" style="overflow-x: visible; overflow-y: scro ll"/>

	15 <tbody id="tbody3" class="test" style="overflow-x: visible; overflow-y: hidd en"/>

	16 </table>

	17 <!-- For table rows. -->

	18 <table>

	19 <tr id="tr1" class="test" style="overflow-x: visible; overflow-y: auto"/>

	20 <tr id="tr2" class="test" style="overflow-x: visible; overflow-y: scroll "/>

	21 <tr id="tr3" class="test" style="overflow-x: visible; overflow-y: hi dden"/>

	22 </table>
	Julien - ping for review 2015/07/16 14:58:12 Weird indentation. Weird indentation.
	23 <script>

	24 description("This test checks for overflow equality. If overflow-x is visible th en overflow-y should be visible as well.");

	25 var elements = document.getElementsByClassName("test");

	26 for (i = 0; i < elements.length; ++i)

	27 {

	28 computedStyle = getComputedStyle(elements[i]);

	29 overflowX = computedStyle.getPropertyValue('overflow-x');

	30 overflowY = computedStyle.getPropertyValue('overflow-y');

	31 if (overflowX == "visible" && overflowX != overflowY)

	32 testFailed(elements[i].id + ": overflow-y should be visible. Was " + ove rflowY + ".");

	33 else

	34 testPassed(elements[i].id + ": overflow-x is either not visible or both overflow values are visible.");
	Julien - ping for review 2015/07/16 14:58:12 Interestingly the testing only convers overflow-x, Interestingly the testing only convers overflow-x, not overflow-y (overflow-x is always visible). We should probably test the symmetrical case. I would argue extensively but at least one value for smoke testing would be good.
	35 }

	36 </script>

OLD	NEW