Reliably cancel in-progress CryptoResult(Impl) upon shutdown.

Source/platform/exported/WebCryptoResult.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 15 matching lines @@
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "public/platform/WebCrypto.h"
 
 #include "platform/CryptoResult.h"
 #include "platform/heap/Heap.h"
-#include <string.h>
 
 namespace blink {
 
 void WebCryptoResult::completeWithError(WebCryptoErrorType errorType, const WebString& errorDetails)
 {
-    m_impl->completeWithError(errorType, errorDetails);
+    if (!m_cancel->cancelled())

[eroman, 2015/07/31 23:40:30]

You could call the wrapper method for these:

  if (!cancelled())
     ...

[sof, 2015/08/01 06:44:31]

Done.

+        m_impl->completeWithError(errorType, errorDetails);
     reset();
 }
 
 void WebCryptoResult::completeWithBuffer(const void* bytes, unsigned bytesSize)
 {
-    m_impl->completeWithBuffer(bytes, bytesSize);
+    if (!m_cancel->cancelled())
+        m_impl->completeWithBuffer(bytes, bytesSize);
     reset();
 }
 
 void WebCryptoResult::completeWithJson(const char* utf8Data, unsigned length)
 {
-    m_impl->completeWithJson(utf8Data, length);
+    if (!m_cancel->cancelled())
+        m_impl->completeWithJson(utf8Data, length);
     reset();
 }
 
 void WebCryptoResult::completeWithBoolean(bool b)
 {
-    m_impl->completeWithBoolean(b);
+    if (!m_cancel->cancelled())
+        m_impl->completeWithBoolean(b);
     reset();
 }
 
 void WebCryptoResult::completeWithKey(const WebCryptoKey& key)
 {
     ASSERT(!key.isNull());
-    m_impl->completeWithKey(key);
+    if (!m_cancel->cancelled())
+        m_impl->completeWithKey(key);
     reset();
 }
 
 void WebCryptoResult::completeWithKeyPair(const WebCryptoKey& publicKey, const WebCryptoKey& privateKey)
 {
     ASSERT(!publicKey.isNull());
     ASSERT(!privateKey.isNull());
-    m_impl->completeWithKeyPair(publicKey, privateKey);
+    if (!m_cancel->cancelled())
+        m_impl->completeWithKeyPair(publicKey, privateKey);
     reset();
 }
 
 bool WebCryptoResult::cancelled() const
 {
-    return m_impl->cancelled();
+    return m_cancel->cancelled();
 }
 
-WebCryptoResult::WebCryptoResult(const PassRefPtrWillBeRawPtr<CryptoResult>& impl)
+WebCryptoResult::WebCryptoResult(const PassRefPtrWillBeRawPtr<CryptoResult>& impl, const PassRefPtr<CryptoResultCancel>& cancel)
     : m_impl(impl)
+    , m_cancel(cancel)
 {
     ASSERT(m_impl.get());
+    ASSERT(m_cancel.get());
 }
 
 void WebCryptoResult::reset()
 {
     m_impl.reset();
+    m_cancel.reset();
 }
 
 void WebCryptoResult::assign(const WebCryptoResult& o)
 {
     m_impl = o.m_impl;
+    m_cancel = o.m_cancel;
 }
 
 } // namespace blink