Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: Source/modules/crypto/CryptoResultImpl.h

Issue 1228373006: Reliably cancel in-progress CryptoResult(Impl) upon shutdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: non-oilpan compile fix Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 22 matching lines...) Expand all
33 33
34 #include "bindings/core/v8/ScriptPromise.h" 34 #include "bindings/core/v8/ScriptPromise.h"
35 #include "core/dom/ExceptionCode.h" 35 #include "core/dom/ExceptionCode.h"
36 #include "modules/ModulesExport.h" 36 #include "modules/ModulesExport.h"
37 #include "platform/CryptoResult.h" 37 #include "platform/CryptoResult.h"
38 #include "public/platform/WebCrypto.h" 38 #include "public/platform/WebCrypto.h"
39 #include "wtf/Forward.h" 39 #include "wtf/Forward.h"
40 40
41 namespace blink { 41 namespace blink {
42 42
43 class ScriptPromiseResolver;
44 MODULES_EXPORT ExceptionCode webCryptoErrorToExceptionCode(WebCryptoErrorType); 43 MODULES_EXPORT ExceptionCode webCryptoErrorToExceptionCode(WebCryptoErrorType);
45 44
46 // Wrapper around a Promise to notify completion of the crypto operation. 45 // Wrapper around a Promise to notify completion of the crypto operation.
47 // 46 //
48 // The thread on which CryptoResultImpl was created on is referred to as the 47 // The thread on which CryptoResultImpl was created on is referred to as the
49 // "origin thread". 48 // "origin thread".
50 // 49 //
51 // * At creation time there must be an active ExecutionContext. 50 // * At creation time there must be an active ExecutionContext.
52 // * The CryptoResult interface must only be called from the origin thread. 51 // * The CryptoResult interface must only be called from the origin thread.
53 // * ref(), deref(), cancelled() and cancel() can be called from any thread. 52 // * ref(), deref(), cancelled() and cancel() can be called from any thread.
54 // * One of the completeWith***() functions must be called, or the 53 // * One of the completeWith***() functions must be called, or the
55 // m_resolver will be leaked until the ExecutionContext is destroyed. 54 // m_resolver will be leaked until the ExecutionContext is destroyed.
56 class CryptoResultImpl final : public CryptoResult { 55 class CryptoResultImpl final : public CryptoResult {
57 public: 56 public:
57 static PassRefPtrWillBeRawPtr<CryptoResultImpl> create(ScriptState*);
58
58 ~CryptoResultImpl(); 59 ~CryptoResultImpl();
59 60
60 static PassRefPtrWillBeRawPtr<CryptoResultImpl> create(ScriptState*);
61
62 void completeWithError(WebCryptoErrorType, const WebString&) override; 61 void completeWithError(WebCryptoErrorType, const WebString&) override;
63 void completeWithBuffer(const void* bytes, unsigned bytesSize) override; 62 void completeWithBuffer(const void* bytes, unsigned bytesSize) override;
64 void completeWithJson(const char* utf8Data, unsigned length) override; 63 void completeWithJson(const char* utf8Data, unsigned length) override;
65 void completeWithBoolean(bool) override; 64 void completeWithBoolean(bool) override;
66 void completeWithKey(const WebCryptoKey&) override; 65 void completeWithKey(const WebCryptoKey&) override;
67 void completeWithKeyPair(const WebCryptoKey& publicKey, const WebCryptoKey& privateKey) override; 66 void completeWithKeyPair(const WebCryptoKey& publicKey, const WebCryptoKey& privateKey) override;
68 bool cancelled() const override; 67 bool cancelled() const override;
69 68
70 // If called after completion (including cancellation) will return an empty 69 // If called after completion (including cancellation) will return an empty
71 // ScriptPromise. 70 // ScriptPromise.
72 ScriptPromise promise(); 71 ScriptPromise promise();
73 72
73 DECLARE_VIRTUAL_TRACE();
74
74 private: 75 private:
75 class Resolver; 76 class Resolver;
76 explicit CryptoResultImpl(ScriptState*); 77 explicit CryptoResultImpl(ScriptState*);
77 78
78 void clearResolver(); 79 void clearResolver();
79 void cancel(); 80 void cancel();
80 81
81 // FIXME: ScriptPromiseResolver should not be exported. 82 RawPtrWillBeMember<Resolver> m_resolver;
82 // Instead, use ScriptPromise.
83 ScriptPromiseResolver* m_resolver;
84 volatile int m_cancelled; 83 volatile int m_cancelled;
85 }; 84 };
86 85
87 } // namespace blink 86 } // namespace blink
88 87
89 #endif 88 #endif // CryptoResultImpl_h
OLDNEW
« no previous file with comments | « no previous file | Source/modules/crypto/CryptoResultImpl.cpp » ('j') | Source/modules/crypto/CryptoResultImpl.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698