Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Unified Diff: src/objects.cc

Issue 1228373004: Allow setting accessor infos over read-only but configurable properties. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index d60fb7c1aaa356611a6d8d8f4115a2cfeb16dbef..0aa2da678656aac9189f2fb5863de0a4ba718a17 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -6346,7 +6346,7 @@ MaybeHandle<Object> JSObject::SetAccessor(Handle<JSObject> object,
// ES5 forbids turning a property into an accessor if it's not
// configurable. See 8.6.1 (Table 5).
- if (it.IsFound() && (it.IsReadOnly() || !it.IsConfigurable())) {
+ if (it.IsFound() && !it.IsConfigurable()) {
return it.factory()->undefined_value();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698