Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1228353008: Remove W3CImportExpectations entries already fixed in upstream (Closed)

Created:
5 years, 5 months ago by kochi
Modified:
5 years, 5 months ago
Reviewers:
tkent, hayato
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Remove W3CImportExpectations entries already fixed in upstream The original issue was already fixed in the following change: https://github.com/w3c/web-platform-tests/commit/4b92f1e66bfd9f7fc8e187cfc778f30ad3d59d1b and its test failure was fixed in my pull req: https://github.com/w3c/web-platform-tests/commit/f518ffa5a1ba331cd1a13b41cc16dca735bdef11 TestExpectations is also updated to match the upstream changes, after running update-w3c-deps script. BUG=505364 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199013

Patch Set 1 #

Patch Set 2 : update-w3c-tests and update TestExpectations #

Patch Set 3 : TestExpectatons update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -355 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 chunks +0 lines, -6 lines 0 comments Download
M LayoutTests/W3CImportExpectations View 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/imported/csswg-test/css-writing-modes-3/inline-block-alignment-new-002.xht View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/imported/csswg-test/css-writing-modes-3/inline-block-alignment-new-002-expected.xht View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/imported/csswg-test/css-writing-modes-3/inline-block-alignment-new-003.xht View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/imported/csswg-test/css-writing-modes-3/inline-block-alignment-new-003-expected.xht View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/imported/csswg-test/css-writing-modes-3/inline-block-alignment-new-004.xht View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/imported/csswg-test/css-writing-modes-3/inline-block-alignment-new-004-expected.xht View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/imported/csswg-test/css-writing-modes-3/inline-block-alignment-new-005.xht View 1 2 chunks +1 line, -2 lines 0 comments Download
M LayoutTests/imported/csswg-test/css-writing-modes-3/inline-block-alignment-new-005-expected.xht View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/imported/csswg-test/css-writing-modes-3/inline-block-alignment-new-006.xht View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/imported/csswg-test/css-writing-modes-3/inline-block-alignment-new-008.xht View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/imported/csswg-test/css-writing-modes-3/inline-block-alignment-new-009.xht View 1 1 chunk +0 lines, -1 line 0 comments Download
A LayoutTests/imported/web-platform-tests/html/rendering/non-replaced-elements/the-fieldset-element-0/min-width-not-important.html View 1 1 chunk +54 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/html/rendering/non-replaced-elements/the-fieldset-element-0/min-width-not-important-expected.html View 1 1 chunk +21 lines, -0 lines 0 comments Download
D LayoutTests/imported/web-platform-tests/shadow-dom/elements-and-dom-objects/shadowroot-object/shadowroot-methods/test-002.html View 1 1 chunk +0 lines, -83 lines 0 comments Download
D LayoutTests/imported/web-platform-tests/shadow-dom/elements-and-dom-objects/shadowroot-object/shadowroot-methods/test-003.html View 1 1 chunk +0 lines, -154 lines 0 comments Download
M LayoutTests/imported/web-platform-tests/shadow-dom/elements-and-dom-objects/shadowroot-object/shadowroot-methods/test-004.html View 1 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/imported/web-platform-tests/shadow-dom/elements-and-dom-objects/shadowroot-object/shadowroot-methods/test-005.html View 1 1 chunk +0 lines, -80 lines 0 comments Download
M LayoutTests/imported/web-platform-tests/shadow-dom/elements-and-dom-objects/shadowroot-object/shadowroot-methods/test-006.html View 1 2 chunks +17 lines, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/shadow-dom/shadow-trees/content-pseudo-element/test-001.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/shadow-dom/shadow-trees/content-pseudo-element/test-002.html View 1 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/imported/web-platform-tests/shadow-dom/shadow-trees/text-decoration-001.html View 1 1 chunk +22 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/shadow-dom/shadow-trees/text-decoration-001-expected.html View 1 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/shadow-dom/styles/not-apply-in-shadow-root-001.html View 1 1 chunk +39 lines, -0 lines 0 comments Download
A + LayoutTests/imported/web-platform-tests/shadow-dom/styles/not-apply-in-shadow-root-001-expected.html View 1 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
kochi
PTAL
5 years, 5 months ago (2015-07-16 04:05:13 UTC) #2
tkent
Please run update-w3c-deps in this CL to confirm unskipped tests work well.
5 years, 5 months ago (2015-07-16 04:31:36 UTC) #3
kochi
On 2015/07/16 04:31:36, tkent wrote: > Please run update-w3c-deps in this CL to confirm unskipped ...
5 years, 5 months ago (2015-07-16 05:09:14 UTC) #4
tkent
On 2015/07/16 05:09:14, Takayoshi Kochi wrote: > In that case, shall I also update TestExpectations ...
5 years, 5 months ago (2015-07-16 05:14:43 UTC) #5
kochi
On 2015/07/16 05:14:43, tkent wrote: > On 2015/07/16 05:09:14, Takayoshi Kochi wrote: > > In ...
5 years, 5 months ago (2015-07-16 06:12:51 UTC) #6
kochi
Could you take another look?
5 years, 5 months ago (2015-07-16 06:48:46 UTC) #7
tkent
lgtm
5 years, 5 months ago (2015-07-16 07:33:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228353008/40001
5 years, 5 months ago (2015-07-16 07:36:51 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=199013
5 years, 5 months ago (2015-07-16 07:41:06 UTC) #11
kochi
5 years, 5 months ago (2015-07-16 08:03:05 UTC) #12
Message was sent while issue was closed.
On 2015/07/16 07:41:06, commit-bot: I haz the power wrote:
> Committed patchset #3 (id:40001) as
> https://src.chromium.org/viewvc/blink?view=rev&revision=199013

Oops - I forgot to remove "NOTRY=true" line in the description...
After including test changes, I should have removed the line.

I hope this does not break the tree, but will watch out for a while.

Powered by Google App Engine
This is Rietveld 408576698