Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1228353007: Move InstallerDelegateTest from ChromeShellTest to ChromePublicTest (Closed)

Created:
5 years, 5 months ago by pkotwicz
Modified:
5 years, 5 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move InstallerDelegateTest from ChromeShellTest to ChromePublicTest This CL makes InstallerDelegateTest an instrumentation test and moves it to ChromePublicTest. BUG=505040 TEST=None TBR=dfalcantara Committed: https://crrev.com/e0c4d057ebf874d3d4efef41c08f4b6666438378 Cr-Commit-Position: refs/heads/master@{#339751}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -169 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/banners/InstallerDelegate.java View 3 chunks +4 lines, -0 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/banners/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java View 1 chunk +0 lines, -168 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
pkotwicz
dfalcantara@ PTAL
5 years, 5 months ago (2015-07-21 19:30:59 UTC) #4
gone
lgtm
5 years, 5 months ago (2015-07-21 20:51:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228353007/60001
5 years, 5 months ago (2015-07-21 20:52:13 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 5 months ago (2015-07-21 21:31:29 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 21:32:22 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e0c4d057ebf874d3d4efef41c08f4b6666438378
Cr-Commit-Position: refs/heads/master@{#339751}

Powered by Google App Engine
This is Rietveld 408576698