Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 1228353004: Fix test case for crbug/507070. (Closed)

Created:
5 years, 5 months ago by Yang
Modified:
5 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix test case for crbug/507070. --debug-code causes full-codegen on arm64 to emit different number of calls, which confuses the debugger when on-stack replacing code with recompiled debug version on-stack. BUG=chromium:507070 TBR=mstarzinger@chromium.org LOG=N Committed: https://crrev.com/541aa57718ecdd0ff192e89e76c5140cd2ad2a5d Cr-Commit-Position: refs/heads/master@{#29638}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/mjsunit/regress/regress-crbug-507070.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 5 months ago (2015-07-14 08:25:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228353004/1
5 years, 5 months ago (2015-07-14 08:25:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-14 08:50:15 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/541aa57718ecdd0ff192e89e76c5140cd2ad2a5d Cr-Commit-Position: refs/heads/master@{#29638}
5 years, 5 months ago (2015-07-14 08:50:25 UTC) #5
Michael Starzinger
5 years, 5 months ago (2015-07-14 11:46:39 UTC) #6
Message was sent while issue was closed.
LGTM (rubber-stamped).

Powered by Google App Engine
This is Rietveld 408576698