Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1228333004: Move code that doesn't depend on PPAPI out of remoting/client/plugin (Closed)

Created:
5 years, 5 months ago by Sergey Ulanov
Modified:
5 years, 5 months ago
Reviewers:
dcaiafa
CC:
chromium-reviews, scheib+watch_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move code that doesn't depend on PPAPI out of remoting/client/plugin remoting/client/plugin contained some files that didn't depend on PPAPI and had unittests. Once the plugin is removed from chrome the plugin will only be compiled for PNaCl, but in order to keep the unittests working these files will still need to be compiled natively. Moving them out of the plugin directory makes it clear which files are compiled only for PNaCl. Also the moved files are not specific to the plugin and would be useful in a native app if we were to implement one. BUG=510271 Committed: https://crrev.com/652b4b61384e9224e61971e64096815f116e8970 Cr-Commit-Position: refs/heads/master@{#338977}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1766 lines) Patch
M remoting/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
A + remoting/client/empty_cursor_filter.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + remoting/client/empty_cursor_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/client/empty_cursor_filter_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/client/normalizing_input_filter_cros.h View 2 chunks +6 lines, -2 lines 0 comments Download
A + remoting/client/normalizing_input_filter_cros.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/client/normalizing_input_filter_cros_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/client/normalizing_input_filter_mac.h View 2 chunks +6 lines, -1 line 0 comments Download
A + remoting/client/normalizing_input_filter_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/client/normalizing_input_filter_mac_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/client/plugin/BUILD.gn View 2 chunks +0 lines, -29 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D remoting/client/plugin/empty_cursor_filter.h View 1 chunk +0 lines, -43 lines 0 comments Download
D remoting/client/plugin/empty_cursor_filter.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D remoting/client/plugin/empty_cursor_filter_unittest.cc View 1 chunk +0 lines, -132 lines 0 comments Download
D remoting/client/plugin/normalizing_input_filter_cros.h View 1 chunk +0 lines, -61 lines 0 comments Download
D remoting/client/plugin/normalizing_input_filter_cros.cc View 1 chunk +0 lines, -216 lines 0 comments Download
D remoting/client/plugin/normalizing_input_filter_cros_unittest.cc View 1 chunk +0 lines, -291 lines 0 comments Download
D remoting/client/plugin/normalizing_input_filter_mac.h View 1 chunk +0 lines, -65 lines 0 comments Download
D remoting/client/plugin/normalizing_input_filter_mac.cc View 1 chunk +0 lines, -82 lines 0 comments Download
D remoting/client/plugin/normalizing_input_filter_mac_unittest.cc View 1 chunk +0 lines, -221 lines 0 comments Download
M remoting/client/plugin/pepper_cursor_setter.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/plugin/pepper_mouse_locker.cc View 1 chunk +1 line, -1 line 0 comments Download
D remoting/client/plugin/touch_input_scaler.h View 1 chunk +0 lines, -48 lines 0 comments Download
D remoting/client/plugin/touch_input_scaler.cc View 1 chunk +0 lines, -86 lines 0 comments Download
D remoting/client/plugin/touch_input_scaler_unittest.cc View 1 chunk +0 lines, -374 lines 0 comments Download
A + remoting/client/touch_input_scaler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/client/touch_input_scaler.cc View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/client/touch_input_scaler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting_nacl.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting_srcs.gypi View 3 chunks +8 lines, -8 lines 0 comments Download
M remoting/remoting_test.gypi View 3 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
Sergey Ulanov
5 years, 5 months ago (2015-07-15 00:18:30 UTC) #2
dcaiafa
lgtm
5 years, 5 months ago (2015-07-15 23:38:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228333004/1
5 years, 5 months ago (2015-07-16 00:37:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/92152) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 5 months ago (2015-07-16 00:43:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228333004/1
5 years, 5 months ago (2015-07-16 00:45:22 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/58328) linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 5 months ago (2015-07-16 00:48:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228333004/1
5 years, 5 months ago (2015-07-16 01:10:28 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/108937) linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 5 months ago (2015-07-16 01:15:13 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228333004/1
5 years, 5 months ago (2015-07-16 01:38:47 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/78940) (exceeded global retry quota)
5 years, 5 months ago (2015-07-16 01:50:43 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228333004/20001
5 years, 5 months ago (2015-07-16 02:05:14 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-16 03:06:10 UTC) #23
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 03:06:59 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/652b4b61384e9224e61971e64096815f116e8970
Cr-Commit-Position: refs/heads/master@{#338977}

Powered by Google App Engine
This is Rietveld 408576698