Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 12283027: Merge 182128 (Closed)

Created:
7 years, 10 months ago by Chris Evans
Modified:
7 years, 10 months ago
Reviewers:
meacer
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Merge 182128 > Add validation to length, packets and packet_length parameters > of the Usb Api. Parameter limits are determined from the following: > > packets: 4MB from http://msdn.microsoft.com/en-us/library/windows/hardware/ff538112(v=vs.85).aspx > packet_length: 65k since wMaxPacketSize is 16bit integer: http://msdn.microsoft.com/en-us/library/ee437177.aspx > > BUG=169765 > R=gdk@chromium.org,miket@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/12096024 TBR=meacer@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182893

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -10 lines) Patch
M chrome/browser/extensions/api/usb/usb_api.cc View 4 chunks +25 lines, -3 lines 0 comments Download
M chrome/browser/usb/usb_device.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/usb/invalid_length_transfer/test.js View 3 chunks +31 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Chris Evans
7 years, 10 months ago (2013-02-16 02:13:12 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698