Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: Source/WebCore/rendering/RenderBlock.cpp

Issue 12283026: Merge 142657 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/multicol/span/list-multi-column-crash-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/rendering/RenderBlock.cpp
===================================================================
--- Source/WebCore/rendering/RenderBlock.cpp (revision 143079)
+++ Source/WebCore/rendering/RenderBlock.cpp (working copy)
@@ -529,13 +529,10 @@
|| curr->isInlineBlockOrInlineTable())
return 0;
- // FIXME: Table manages its own table parts, most of which are RenderBoxes.
- // Multi-column code cannot handle splitting the flow in table. Disabling it
- // to prevent crashes.
- // Similarly, RenderButton maintains an anonymous block child and overrides
- // addChild() to prevent itself from having additional direct children. This
- // causes problems for split flows.
- if (curr->isTable() || curr->isRenderButton())
+ // FIXME: Tables, RenderButtons, and RenderListItems all do special management
+ // of their children that breaks when the flow is split through them. Disabling
+ // multi-column for them to avoid this problem.
+ if (curr->isTable() || curr->isRenderButton() || curr->isListItem())
return 0;
RenderBlock* currBlock = toRenderBlock(curr);
« no previous file with comments | « LayoutTests/fast/multicol/span/list-multi-column-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698