JSON Compiler should convert the namespace value in lowerCamelCase to unix_name for the referenced …

JSON Compiler should convert the namespace value in lowerCamelCase to unix_name for the referenced dependency.

BUG=159265
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184263

[SanjoyPal, 2013-02-16 01:28:54]

JSON schema compiler generates namespace webRequest while parsing
web_request_internal.json http://goo.gl/NgCGX.

[not at google - send to devlin, 2013-02-16 02:50:01]

lgtm

https://codereview.chromium.org/12283025/diff/1/tools/json_schema_compiler/co...
File tools/json_schema_compiler/compiler.py (right):

https://codereview.chromium.org/12283025/diff/1/tools/json_schema_compiler/co...
tools/json_schema_compiler/compiler.py:23: from model import Model
from model import Mode, UnixName

https://codereview.chromium.org/12283025/diff/1/tools/json_schema_compiler/co...
tools/json_schema_compiler/compiler.py:114: os.path.dirname(schema),
UnixName(referenced_schema) + '.json')
cleanup: '%s.json' % UnixName(referenced_schema)

[SanjoyPal, 2013-02-19 19:22:02]

Fixed.

https://codereview.chromium.org/12283025/diff/1/tools/json_schema_compiler/co...
File tools/json_schema_compiler/compiler.py (right):

https://codereview.chromium.org/12283025/diff/1/tools/json_schema_compiler/co...
tools/json_schema_compiler/compiler.py:23: from model import Model
On 2013/02/16 02:50:02, kalman wrote:
> from model import Mode, UnixName

Done.

https://codereview.chromium.org/12283025/diff/1/tools/json_schema_compiler/co...
tools/json_schema_compiler/compiler.py:114: os.path.dirname(schema),
UnixName(referenced_schema) + '.json')
On 2013/02/16 02:50:02, kalman wrote:
> cleanup: '%s.json' % UnixName(referenced_schema)

Done.

[commit-bot: I haz the power, 2013-02-22 21:56:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ncj674@motorola.com/12283025/4001

[commit-bot: I haz the power, 2013-02-22 21:56:26]

Presubmit check for 12283025-4001 failed and returned exit status 1.

INFO:root:Found 2 file(s).

testChoices (__main__.ModelTest) ... ok
testDescription (__main__.ModelTest) ... ok
testHasFunctions (__main__.ModelTest) ... ok
testHasProperties (__main__.ModelTest) ... ok
testHasTypes (__main__.ModelTest) ... ok
testNamespaces (__main__.ModelTest) ... ok
testProperties (__main__.ModelTest) ... ok
testPropertyNotImplemented (__main__.ModelTest) ... ok
testPropertyUnixName (__main__.ModelTest) ... ok
testUnixName (__main__.ModelTest) ... ok

----------------------------------------------------------------------
Ran 10 tests in 0.593s

OK
testArrayAsType (__main__.CppTypeGeneratorTest) ... ok
testGenerateIncludesAndForwardDeclarations (__main__.CppTypeGeneratorTest) ...
ok
testGenerateIncludesAndForwardDeclarationsDependencies
(__main__.CppTypeGeneratorTest) ... FAIL
testGetCppTypeArray (__main__.CppTypeGeneratorTest) ... ok
testGetCppTypeIncludedRef (__main__.CppTypeGeneratorTest) ... ok
testGetCppTypeLocalRef (__main__.CppTypeGeneratorTest) ... ok
testGetCppTypeSimple (__main__.CppTypeGeneratorTest) ... ok
testGetCppTypeWithPadForGeneric (__main__.CppTypeGeneratorTest) ... ok
testStringAsType (__main__.CppTypeGeneratorTest) ... ok

======================================================================
FAIL: testGenerateIncludesAndForwardDeclarationsDependencies
(__main__.CppTypeGeneratorTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./cpp_type_generator_test.py", line 78, in
testGenerateIncludesAndForwardDeclarationsDependencies
    manager.GenerateForwardDeclarations().Render())
AssertionError: 'namespace browserAction {\n}\nnamespace fontSettings {\n}' !=
u'namespace browser_action {\n}\nnamespace font_settings {\n}'

----------------------------------------------------------------------
Ran 9 tests in 1.037s

FAILED (failures=1)
testClassname (__main__.CppUtilTest) ... ok
testNamespaceDeclaration (__main__.CppUtilTest) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.000s

OK
testBasicEvent (__main__.DartTest) ... ok
testBasicFunction (__main__.DartTest) ... ok
testBasicType (__main__.DartTest) ... ok
testComments (__main__.DartTest) ... ok
testComplexType (__main__.DartTest) ... ok
testEmptyNamespace (__main__.DartTest) ... ok
testEmptyType (__main__.DartTest) ... ok
testOpratableType (__main__.DartTest) ... ok
testTags (__main__.DartTest) ... ok

----------------------------------------------------------------------
Ran 9 tests in 1.149s

OK
testNocompile (__main__.JsonSchemaUnittest) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.006s

OK
testJsFunctionNameToClassName (__main__.SchemaUtilTest) ... ok
testStripNamespace (__main__.SchemaUtilTest) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.000s

OK
testAppend (__main__.CodeTest) ... ok
testBlock (__main__.CodeTest) ... ok
testComment (__main__.CodeTest) ... ok
testCommentWithSpecialCharacters (__main__.CodeTest) ... ok
testConcat (__main__.CodeTest) ... ok
testConcatErrors (__main__.CodeTest) ... ok
testIsEmpty (__main__.CodeTest) ... ok
testSubstitute (__main__.CodeTest) ... ok
testSubstituteErrors (__main__.CodeTest) ... ok

----------------------------------------------------------------------
Ran 9 tests in 0.001s

OK
testArrayOfCallbacks (__main__.IdlSchemaTest) ... ok
testCallbackComment (__main__.IdlSchemaTest) ... ok
testCallbackWithArrayArgument (__main__.IdlSchemaTest) ... ok
testEnum (__main__.IdlSchemaTest) ... ok
testFunctionComment (__main__.IdlSchemaTest) ... ok
testInternalNamespace (__main__.IdlSchemaTest) ... ok
testLegalValues (__main__.IdlSchemaTest) ... ok
testMemberOrdering (__main__.IdlSchemaTest) ... ok
testNoCompile (__main__.IdlSchemaTest) ... ok
testReservedWords (__main__.IdlSchemaTest) ... ok
testSimpleCallbacks (__main__.IdlSchemaTest) ... ok

----------------------------------------------------------------------
Ran 11 tests in 1.858s

OK
Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/tools/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/tools/json_schema_compiler/PRESUBMIT.py
Running ./model_test.py
Running ./cpp_type_generator_test.py
Running ./cpp_util_test.py
Running ./dart_generator_test.py
Running ./json_schema_test.py
Running ./schema_util_test.py
Running ./code_test.py
Running ./idl_schema_test.py

** Presubmit ERRORS **
./cpp_type_generator_test.py failed!
Command ./cpp_type_generator_test.py --verbose returned non-zero exit status 1
in /b/commit-queue/workdir/chromium/tools/json_schema_compiler

Presubmit checks took 6.6s to calculate.

[SanjoyPal, 2013-02-23 00:06:58]

JSON Compiler should convert the namespace value in lowerCamelCase to unix_name
for the referenced dependency.

BUG=159265

[commit-bot: I haz the power, 2013-02-23 00:09:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ncj674@motorola.com/12283025/10001

[commit-bot: I haz the power, 2013-02-23 02:33:34]

Change committed as 184263