Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1228293003: Return early in automaticTrackSelectionForUpdatedUserPreference() (Closed)

Created:
5 years, 5 months ago by philipj_slow
Modified:
5 years, 5 months ago
Reviewers:
fs, sigbjornf
CC:
blink-reviews, nessy, mlamouri+watch-blink_chromium.org, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, vcarbune.chromium
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Return early in automaticTrackSelectionForUpdatedUserPreference() If there are no text tracks, nothing in the method does anything, except updateTextTrackDisplay() which will create the text track container which is not needed yet. BUG=457850 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198767

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Source/core/html/HTMLMediaElement.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228293003/1
5 years, 5 months ago (2015-07-13 09:07:23 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-13 10:36:03 UTC) #4
philipj_slow
PTAL
5 years, 5 months ago (2015-07-13 10:54:40 UTC) #6
fs
Right, I was thinking this too... LGTM
5 years, 5 months ago (2015-07-13 11:01:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228293003/1
5 years, 5 months ago (2015-07-13 11:12:45 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 11:16:08 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198767

Powered by Google App Engine
This is Rietveld 408576698