Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2344)

Unified Diff: chrome/browser/resources/downloads/manager.js

Issue 1228263002: Fix downloads-related web_dev_style presubmit issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dl-rough-draft2
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/downloads/manager.js
diff --git a/chrome/browser/resources/downloads/manager.js b/chrome/browser/resources/downloads/manager.js
index 85a4fde324d31b9470afe6d0baeb3b37a32c4d9f..e7c01e220d84cb7feffabfc35d63fd0475e20727 100644
--- a/chrome/browser/resources/downloads/manager.js
+++ b/chrome/browser/resources/downloads/manager.js
@@ -24,7 +24,7 @@ cr.define('downloads', function() {
this.searchText_ = searchText;
$('downloads-summary-text').textContent = this.searchText_ ?
- loadTimeData.getStringF('searchresultsfor', this.searchText_) : '';
+ loadTimeData.getStringF('searchResultsFor', this.searchText_) : '';
// Split quoted terms (e.g., 'The "lazy" dog' => ['The', 'lazy', 'dog']).
function trim(s) { return s.trim(); }
@@ -109,13 +109,13 @@ cr.define('downloads', function() {
var noDownloadsOrResults = $('no-downloads-or-results');
noDownloadsOrResults.textContent = loadTimeData.getString(
- this.searchText_ ? 'no_search_results' : 'no_downloads');
+ this.searchText_ ? 'noSearchResults' : 'noDownloads');
var hasDownloads = this.size_() > 0;
this.node_.hidden = !hasDownloads;
noDownloadsOrResults.hidden = hasDownloads;
- if (loadTimeData.getBoolean('allow_deleting_history'))
+ if (loadTimeData.getBoolean('allowDeletingHistory'))
$('clear-all').hidden = !hasDownloads || this.searchText_.length > 0;
this.rebuildFocusGrid_();
@@ -181,7 +181,7 @@ cr.define('downloads', function() {
/** @private */
clearAll_: function() {
- if (loadTimeData.getBoolean('allow_deleting_history')) {
+ if (loadTimeData.getBoolean('allowDeletingHistory')) {
chrome.send('clearAll');
this.setSearchText_('');
}
« no previous file with comments | « chrome/browser/resources/downloads/item_view.js ('k') | chrome/browser/resources/md_downloads/downloads.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698